summaryrefslogtreecommitdiff
path: root/x11/kde4-runtime/files/patch-kdesu_kdesu_kdesu.cpp
blob: 2b0b1754bedc6bc912de4214d6e715328aa1523e (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
Fix for https://www.kde.org/info/security/advisory-20160930-1.txt
--- kdesu/kdesu/kdesu.cpp.orig	2014-10-30 23:50:20 UTC
+++ kdesu/kdesu/kdesu.cpp
@@ -141,6 +141,10 @@ int main(int argc, char *argv[])
     {
         KMessageBox::sorry(0, i18n("Cannot execute command '%1'.", QString::fromLocal8Bit(command)));
     }
+    if (result == -2)
+    {
+        KMessageBox::sorry(0, i18n("Cannot execute command '%1'. It contains invalid characters.", QString::fromLocal8Bit(command)));
+    }
 
     return result;
 }
@@ -367,6 +371,12 @@ static int startApp()
         kDebug() << "Don't need password!!\n";
     }
 
+    for (const QChar character : QString::fromLocal8Bit(command)) {
+        if (!character.isPrint() && character.category() != QChar::Other_Surrogate) {
+            return -2;
+        }
+    }
+
     // Start the dialog
     QString password;
     if (needpw)