| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Remove the WWW check for pkg-descr.
PR: 278069
|
| |
|
|
|
|
|
|
|
|
|
| |
This fixes some spurious errors by concatenating continued lines in the
Makefile. The downside of this is that line numbers will get more
askew. I thought I'd get some time to imrove this, but didn't. And
this fix is important to get out now.
PR: 275075
|
|
|
|
|
|
|
|
|
|
|
| |
* Soften the desktop-file-utils message [1]
* Avoid a bogus error on ports that append to DISTFILES. [2]
* Colorize output for warnings and errors. [3]
PR: 271623 [1]
268681 [2]
274981 [3]
Inspired by: yuri [3]
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Check for duplicate distinfo items [1]
* Remove vestiges of SVN [2]
[2] Switch to using `git status` to determine if a file is under git version
control. Also, PL_SVN_IGNORE has been renamed to PL_GIT_IGNORE.
PR: 267168 [1]
267145 [2]
Submitted by: rodrigo [1]
Thanks to: pauamma for the `git status` command [2]
|
|
|
|
| |
Remove some stale WWW warnings for pkg-descr.
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Allow for a plus ('+') in other places in a PORTVERSION [1]
* Check for .dkestop file installation [2]
* Support the new Makefile WWW macro [3]
PR: 265364 [1]
265551 [2]
266068 [3]
Submitted by: Robert Clausecker [1]
se [3]
|
|
|
|
|
|
|
| |
gnome@ no longer uses Marcusom as their staging ground.
Approved by: gnome (nc)
Differential Revision: https://reviews.freebsd.org/D35866
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A big Thank You to the original contributors of these ports:
* "Waitman Gobble" <uzimac@da3m0n8t3r.com>
* Akinori MUSHA aka knu <knu@idaemons.org>
* Alex Dupre <ale@FreeBSD.org>
* Alex Stangl <alex@stangl.us>
* Anders F Bjorklund <afb@users.sourceforge.net>
* Benjamin Lutz
* Brendan Molloy <brendan+freebsd@bbqsrc.net>
* Conrad J. Sabatier <conrads@cox.net>
* Edwin Groothuis (edwin@mavetju.org)
* Emanuel Haupt <ehaupt@FreeBSD.org>
* Gabriel Linder <linder.gabriel@gmail.com>
* Heiner <h.eichmann@gmx.de>
* Ilya A. Arkhipov <rum1cro@yandex.ru>
* John Marino <marino@FreeBSD.org>
* Jun-ichiro itojun Hagino <itojun@itojun.org>
* Kubilay Kocak <koobs@FreeBSD.org>
* Mamoru Sakaue / MwGhennndo
* Martin Kammerhofer
* Matthew Seaman
* Matthew Seaman <m.seaman@infracaninophile.co.uk>
* Matthias Andree <mandree@FreeBSD.org>
* Matthias Schmidt
* Pawel Pekala <pawel@FreeBSD.org>
* Philip M. Gollucci <pgollucci@p6m7g8.com>
* Philipp Wuensche <cryx-ports@h3q.com>
* Richard Gallamore <ultima@FreeBSD.org>
* Romain Tartiere <romain@FreeBSD.org>
* Romain Tartiere <romain@blogreen.org>
* Securedog <securedog@users.sourceforge.jp>
* Sergei Kolobov <sergei@kolobov.com>
* Shaun Amott <shaun@inerd.com>
* Stefan Walter <sw@gegenunendlich.de>
* Stephen Hurd <shurd@FreeBSD.org>
* Timothy Redaelli <drizzt@gufi.org>
* Tom Hukins <tom@FreeBSD.org>
* Vasil Dimov <vd@datamax.bg>
* Vladimir Chukharev
* Yanhui Shen <shen.elf@gmail.com>
* Zane C, Bowers <vvelox@vvelox.net>
* kmoore@FreeBSD.org
With hat: portmgr
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In a discussion with members of the port managers team (tcberner, rene) the issue of conflicting package base names came up.
I have offered to create portlint checks for 2 possible Makefile issues:
1) Conflicting use of ${PKGBASE} of an existing port.
2) Multiple flavors resulting in the same ${PKGBASE}.
The attached patch adds checks for both possible issues:
1) Check for the existence of the new PKGBASE in the INDEX file (if present) and warn if it is used for a different ORIGIN.
2) Generate PKGBASE for all FLAVORS and check for duplicates.
PR: 263807
|
|
|
|
|
|
| |
* Do not strip modifiers from variables when dereferencing.
PR: 262941
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The warning about a CONFLICTS entry matching the package being built
is bogus - the ports system excludes the port being built from the
list of conflicts that is reported by "make list-install-conflicts"
and the other targets that check for conflicts.
It is in fact quite useful to specify CONFLICTS with wildcards that
include the port being built instead of explicitly listing all other
versions (e.g. in case of the mysql or mariadb ports - it is possible
to use mysql[0-9][0-9]-client for example in the mysql57-client port
instead of complex patterns like "mysql5[56]-client mysql80-client"
in an attempt to not match the "57").
Since I'm fixing CONFLICTS entries in a large number of ports and
want to use wildcards as explained above to simplify the entries and
to reduce the maintenance effort (often are CONFLICTS entries stale
when new versions of e.g. mysql are imported).
The bogus portlint messages let maintainers think that the wildcards
need to be adjusted to prevent this "self conflict", leading them to
put back the unnecessarily complex patterns.
The author of portlint has not provided any kind of response to my
request to remove the misleading output sent more than 6 weeks ago.
Due to a maintainer time-out I'm removing the bogus message. The test
and print command are commented out in order to only apply the minimal
change required. The version number is unchanged since I do not want
to introduce a version that does not exist in the upstream sources,
but a portrevision is added to enforce the creation of an updated
package in the official repository.
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Don't check for direct use of commands in PORTNAME [1]
* Split on first '@' to avoid breaking directory detection [2]
* Remove checks for deprecated INSTALLS_ICONS [3]
PR: 229627 [1]
260246 [2]
261556 [3]
Submitted by: gerald [1]
Derek Schrock <dereks@lifeofadishwasher.com> [2]
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Update CONFLICTS check to cover all variables and checks performed by
bsd.port.mk [1]
* Add some other allowed fully-qualified paths [2]
* Don't consider variable substitution when checking DEPENDS [3]
PR: 259813 [2]
259244 [3]
Sybmitted by: se [1]
gerald [2]
Differential Revision: https://reviews.freebsd.org/D32733 [1]
|
|
|
|
|
|
|
|
| |
* Warn about deprecated USE_AUTOTOOLS [1]
* Add support for BROKEN_*
PR: 248487 [1]
257951 [2]
|
|
|
|
|
|
|
|
|
|
| |
* Account for LEGAL_TEXT and per-ARCH DISTFILES in the Makefile sections
[1]
* Relax USE_LDCONFIG checks now that we don't need a specific lib
pattern [2]
PR: 255764 [1]
255651 [2]
|
|
|
|
|
|
|
|
|
|
|
| |
LEGAL is badly maintained, LEGALlint notices quite a number of ports
which mismatch their line in LEGAL. The port itself is always leading.
* math/giacxcas: restrict RESTRICTED_FILES to giac_* only
Differential Revision: https://reviews.freebsd.org/D30061
Reviewed by: portmgr (mat), dch, eadler, marcus
|
|
|
|
|
|
|
| |
* Allow ports without any leading comment section [1]
loader@ submitted a patch on which this was based
* Add a check to make sure the license is actually valid
PR: 255520 [1]
|
|
|
|
|
|
|
|
| |
* Reverse $FreeBSD$ check logic to make the use of them FATAL [1]
* Remove embedded $FreeBSD$
PR: 255153 [1]
Obtained from: lwhsu [1]
With issue report from Tatsuki Makino
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Correct path to apache.mk [1]
* Warn if one declares USE_LDCONFIG without a properly named shared object [2]
* Allow make use-before-declare lazy evaluation in dependencies [3]
PR: 252003 [1]
252181 [2]
244239 [3]
Submitted by: brnrd [1]
Notes:
svn path=/head/; revision=559405
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Do not complain about USE_LDCONFIG32 [1]
* Allow a master port to have its last line be ".endif" [2]
* Attempt to find OPTIONS use in a smarter way [3]
PR: 251431 [1]
251430 [2]
249970 [3]
Submitted by: gerald [1]
Notes:
svn path=/head/; revision=556590
|
|
|
|
|
|
|
|
| |
The makevar padding method was missing leading and trailing variable values
when those values were undefined. Try to be better about this.
Notes:
svn path=/head/; revision=537171
|
|
|
|
| |
Notes:
svn path=/head/; revision=537111
|
|
|
|
|
|
|
|
|
|
| |
Fix typos introduced in previous commits.
PR: 246881
246882
Notes:
svn path=/head/; revision=537110
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Do not be overly critical of macros which are used before declaration in DEPENDS
* Do not treat comments to ONLY_FOR_ARCHS and NOT_FOR_ARCHS as sortable data [1]
* Check for PORTSDIR defined in /etc/make.conf [2]
* Do not warn about ${DISTNAME}${EXTRACT_SFX} in DISTFILES if USE_GITHUB=nodefault [3]
* Thoroughly check for an OPTION description [4]
* Specify flag equivalency for -A in portlint(1) [5]
PR: 246346 [1]
244807 [2]
244741 [3]
244480 [4]
245338 [5]
Submitted by: 0mp [3]
kevans [5]
Notes:
svn path=/head/; revision=537082
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* No longer warn for manpages installed under share/man [1]
* Remove code to combine comments and blank lines in a section [2]
* Remove code to combine comments and blank lines [3]
* USE_PYQT sets the necessary QT USES [4]
* Only warn on lack of INSTALLS_ICONS when USES=gnome is set [5]
* Check for files that have been patched multiple times [6]
PR: 240359 [2]
244480 [3]
240445 [4]
244039 [5]
243600 [6]
Submitted by: 0mp [1] [5]
vladimir.chukharev@gmail.com [4]
swills [6]
Differential Revision: D23896 [1]
Notes:
svn path=/head/; revision=527653
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Relax wording around restrictive licensing [1]
* Remove the check for extra items in the USE/USES section [2]
One is allowed to put any _related_ variables here, and this will always change.
It's easier not to check than to provide wrong recommendations.
* Fix the check for unspecified license files [3]
PR: 240233 [1]
239045 [2]
231303 [3]
Notes:
svn path=/head/; revision=511098
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add check for sensible CMAKE settings to ports-mgmt/portlint [1]
* Do not warn about absolute paths in *_OLD_CMD (when USES=shebangfix is set) [2]
* If an option only has QMAKE_ON or QMAKE_OFF settings, it is flagged as no effect [3]
* Check for options defined per ARCH to make sure we don't have a lot
of false positives. [4]
(Note: [1] was already in PORTREVISION 2).
PR: 232948 [2]
237045 [3]
234888 [4]
Submitted by: adridg [3]
Notes:
svn path=/head/; revision=497951
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a port sets CMAKE variables (CMAKE_ARGS, or the option helpers
like foo_CMAKE_BOOL) then it should have USES=cmake; otherwise
those variables don't make any sense.
This is the slightly simplified version of the patch: there
really shouldn't be options that switch (meta-)build systems.
PORTREVISION bumped because I'm not sure what the versioning
scheme is for portlint.
PR: 235650
Reported by: yuri
Approved by: marcus (maintainer timeout 2 weeks)
Differential Revision: https://reviews.freebsd.org/D19525
Notes:
svn path=/head/; revision=497950
|
|
|
|
| |
Notes:
svn path=/head/; revision=490960
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Handle multiple licenses [1]
* Warn about leading and trailing whitespace in pkg-descr [2]
PR: 233774 [1]
235070 [2]
Submitted by: amdmi3 [1]
swills [2]
Notes:
svn path=/head/; revision=490959
|
|
|
|
|
|
|
|
|
|
|
| |
You can use autoplist with a pkg-plist or PLIST_*. Some ports require this
apparently. Remove these warnings for now until a more robust
duplicate-checking solution can be implemented.
Reported by: koobs
Notes:
svn path=/head/; revision=485359
|
|
|
|
|
|
|
|
|
| |
Fix an uninitialized variable warning in non-Python ports.
Reported by: leres
Notes:
svn path=/head/; revision=482100
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Do not complain about extra FLAVORS in *_DEPENDS. [1]
* Do not fully expand variable dependencies to allow for more granular checks. [2]
* Allow GH_* in USES section. [3]
* Check for duplication between *_USES and USES. [4]
* Check for incorrect use of *_CMAKE_ARGS [5]
* Check that CMAKE_BOOL arguments do not contain a -D flag [5]
* Check for use of autoplist and pkg-plkist or PLIST_FILE. [6]
PR: 231420 [1]
231421 [2]
231422 [3]
231566 [4]
231894 [5]
231865 [6]
Submitted by: db [3] [6]
Notes:
svn path=/head/; revision=481991
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Do not complain about icon installation if USE_QT is defined [1]
* Add support for checking LICENSE_PERMS [2]
* Add a warning when NO_PACKAGE is used [2]
* Per the Porter's handbook, check for sections for USE/USES and FLAVORS [3]
* Check for -on/-off in OPTION names [4]
* Check to make sure the correct LICENSE_FILE_foo is specified [5]
PR: 231122 [1]
231155 [2]
230594 [3]
229280 [4]
231303 [5]
Submitted by: loader [3]
adamw [4]
Notes:
svn path=/head/; revision=479898
|
|
|
|
|
|
|
| |
PR: 230427
Notes:
svn path=/head/; revision=476593
|
|
|
|
| |
Notes:
svn path=/head/; revision=476188
|
|
|
|
|
|
|
| |
"Can not" means "it is possible not to," and "cannot" means "it is impossible to."
Notes:
svn path=/head/; revision=476184
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Be less strict in the check for MASTER_SITE_SUBDIR use.
This change checks that the subdirectory used is actually different
than what is defined in MASTER_SITES_SUBDIRS. To make this easier to
do, support has been added to single-quote variables passed to the
get_makevar* functions. [1]
* Now only PY_FLAVOR is recommended as opposed to FLAVOR. [2]
* Remove an errant ':' when suggesting PY_FLAVOR. [3]
PR: 228227 [1]
Requested by: mat [2]
Reported by: koobs [3]
Notes:
svn path=/head/; revision=473207
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a regression in the mae makepatch check.
Make sure only the patch header is checked, but make sure
to read in the entire patch file. This regression was
introduced in 2.18.0.
PR: 228203
Notes:
svn path=/head/; revision=469758
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Soften the py-* dependency error around flavors.
Now the message is a warning and a suggestion. This is pending more discussion,
but this seems like a good compromise for now.
PR: 225654
Requested by: antoine
Notes:
svn path=/head/; revision=469754
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix the check for duplicate SHEBANG_LANG values [1]
* Check to make sure patch files end with newlines [2]
* Allow flavored *_DEPENDS in the DEPENDS section [3]
* Check that kde:4 OR kde:5 is defined with USE_KDE [4]
* Add a check to make sure pkg-descr is at least a certain number of lines [5]
* Fix a couple of typos [6] [7]
* Allow for any *_DEPENDS item in the DEPENDS section and fix a bug in the
dependency syntax checking [8]
* Add a check to make sure Python dependencies include a FLAVOR [9]
PR: 226709 [1]
226109 [2]
226581 [3]
227255 [5]
227729 [6]
227878 [7]
227556 [8]
225654 [9]
Submitted by: tcberner [4]
0mp [5][6][7]
Differential Revision: D13723 [4]
Notes:
svn path=/head/; revision=469697
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Check for USE_PYQT when USES=pyqt:5 is defined [1]
* Avoid more bogus direct command use warnings. Also try and fix some line numbers [2]
* Check for over-verbose use of magic MASTER_SITES_SUBDIRS [3]
* Do not complain about missing Created by: [4]
* Avoid checking direct command usage in embedded comments [5]
PR: 225615 [1]
225612 [2]
225503 [3]
225781 [5]
Reported by: Jason Bacon <bacon4000@gmail.com> [4]
Notes:
svn path=/head/; revision=462265
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Don't check for direct command use for ONLY_FOR_ARCHS_REASON
and NOT_FOR_ARCHS_REASON when a specific arch has been specified. [1]
* Preserve an original variable value to make sure the check for copying
dependecies is actually performed.
* Don't complain about incon installation if the port is a Qt5 port. [2]
* Check that PLIST_FILES entries do not contain %%FOO% notation. [3]
* Check that DOCS and EXAMPLES are defined as OPTIONS when using %%PORTDOCS%%
and %%PORTEXAMPLES%%. [4]
* Check that if USE_LDCONFIG is defined, then the port installs shared
objects. [5]
* Check that when USE_KDE is defined, then USES=kde:5 is also defined. [6]
* Ignore flavors when trying to find port directories. [7]
* Revert the fix for 221971 (USE_GITHUB). More debate is needed here.
PR: 223285 [1]
223498 [2]
223539 [3]
223541 [4]
223762 [5]
224140 [6]
224245 [7]
Submitted by: adridg [2]
mat [4]
224245 [7]
Notes:
svn path=/head/; revision=457486
|
|
|
|
|
|
|
|
|
| |
Escape a variable in an RE to prevent corruption.
Submitted by: gahr
Notes:
svn path=/head/; revision=455703
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Do not complain about USE_GITHUB before USES [1]
* Make sure each variable in a dependency is fully expanded [2]
* Clean up the earlier checks for BROKEN, etc. to prevent bogus warnings [3]
* 'USE=execinfo' is removed with ports r450351. So stop suggesting to use it [4]
PR: 221971 [1]
221605 [2]
222409 [3]
222653 [4]
Submitted by: amdmi3 [1]
jrm [2]
Yasuhiro KIMURA <yasu@utahime.org> [4]
Notes:
svn path=/head/; revision=451553
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Don't check for absolute paths inside make variables [1]
* Check pkg-plist for use of OPTIONS [1]
* Fix an issue with line number offsets [2]
* Don't alert on double-dollar (VARIABLE) [3]
* Allow BROKEN, IGNORE, DEPRECATED to appear before the *_DEPENDS block [4]
* Check that manpages are not installed into share/man [5]
* Check for a space anywhere between a variable and its value [6]
PR: 221507 [1]
221291 [2]
221397 [3]
221377 [4]
221455 [5]
221219 [6]
Submitted by: Dmitri Goutnik <dg@syrec.org> [4]
Notes:
svn path=/head/; revision=447981
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Trim comments after USE_GCC [1]
* Add a check for redundant SHEBANG_LANG values [2]
* Make sure both USES and USE_* are actually seen before checking
to see if one is included before the other [3]
PR: 221085 [1]
220500 [2]
Submitted by: gerald [1]
Reported by: dbaio [3]
Notes:
svn path=/head/; revision=447208
|