diff options
author | Tijl Coosemans <tijl@FreeBSD.org> | 2019-01-16 11:13:44 +0000 |
---|---|---|
committer | Tijl Coosemans <tijl@FreeBSD.org> | 2019-01-16 11:13:44 +0000 |
commit | 1bf487d3e73d83700f5a4aeb3a9ffbfc6e87856b (patch) | |
tree | 127ae6686665fd0ff97a7bd5f27449299929734e /x11-themes | |
parent | Remove expired port: (diff) |
Fix Qt5 symbol version scripts to put the catch-all clause first. When
a symbol matches multiple clauses the last one takes precedence. If the
catch-all is last it captures everything. In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API. This only affects lld because GNU ld always gives the
catch-all lowest priority.
Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium. Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3] The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one. If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash. Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.
Remove the weak wrappers (make them Linux specific). This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.
[1] https://github.com/qt/qtwebengine/commit/5c2cbfccf9aafb547b0b30914c4056abd25942a4
[2] https://github.com/qt/qtwebengine/commit/2ed5054e3a800fa97c2c9e920ba1e6ea4b6ef2a5
[3] https://github.com/qt/qtwebengine/commit/009f5ebb4bd6e50188671e0815a5dae6afe39db5
Bump all ports that depend on Qt5.
PR: 234070
Exp-run by: antoine
Approved by: kde (adridg)
Notes
Notes:
svn path=/head/; revision=490472
Diffstat (limited to 'x11-themes')
-rw-r--r-- | x11-themes/Kvantum/Makefile | 1 | ||||
-rw-r--r-- | x11-themes/adwaita-qt/Makefile | 2 | ||||
-rw-r--r-- | x11-themes/kf5-breeze-icons/Makefile | 1 | ||||
-rw-r--r-- | x11-themes/kf5-kemoticons/Makefile | 1 | ||||
-rw-r--r-- | x11-themes/kf5-kiconthemes/Makefile | 1 | ||||
-rw-r--r-- | x11-themes/kf5-oxygen-icons5/Makefile | 1 | ||||
-rw-r--r-- | x11-themes/kf5-qqc2-desktop-style/Makefile | 1 | ||||
-rw-r--r-- | x11-themes/lumina-themes/Makefile | 2 | ||||
-rw-r--r-- | x11-themes/lxqt-themes/Makefile | 1 | ||||
-rw-r--r-- | x11-themes/plasma5-breeze-gtk/Makefile | 1 | ||||
-rw-r--r-- | x11-themes/plasma5-breeze/Makefile | 1 | ||||
-rw-r--r-- | x11-themes/plasma5-kde-gtk-config/Makefile | 1 | ||||
-rw-r--r-- | x11-themes/plasma5-oxygen/Makefile | 1 | ||||
-rw-r--r-- | x11-themes/plasma5-plasma-workspace-wallpapers/Makefile | 1 | ||||
-rw-r--r-- | x11-themes/qt5-style-plugins/Makefile | 2 | ||||
-rw-r--r-- | x11-themes/qtcurve-kf5/Makefile | 2 | ||||
-rw-r--r-- | x11-themes/qtcurve-qt5/Makefile | 2 | ||||
-rw-r--r-- | x11-themes/qtcurve/Makefile | 2 | ||||
-rw-r--r-- | x11-themes/xfce-evolution/Makefile | 1 |
19 files changed, 19 insertions, 6 deletions
diff --git a/x11-themes/Kvantum/Makefile b/x11-themes/Kvantum/Makefile index 1840e3080db3..9863723015aa 100644 --- a/x11-themes/Kvantum/Makefile +++ b/x11-themes/Kvantum/Makefile @@ -3,6 +3,7 @@ PORTNAME= Kvantum DISTVERSIONPREFIX= V DISTVERSION= 0.10.8 +PORTREVISION= 1 CATEGORIES= x11-themes MAINTAINER= rigoletto@FreeBSD.org diff --git a/x11-themes/adwaita-qt/Makefile b/x11-themes/adwaita-qt/Makefile index 61ddf373c805..1e5a0bfd91e0 100644 --- a/x11-themes/adwaita-qt/Makefile +++ b/x11-themes/adwaita-qt/Makefile @@ -3,7 +3,7 @@ PORTNAME= adwaita-qt DISTVERSION= 1.0 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= x11-themes MAINTAINER= tcberner@FreeBSD.org diff --git a/x11-themes/kf5-breeze-icons/Makefile b/x11-themes/kf5-breeze-icons/Makefile index 20d6b7c595cd..41d098173b18 100644 --- a/x11-themes/kf5-breeze-icons/Makefile +++ b/x11-themes/kf5-breeze-icons/Makefile @@ -2,6 +2,7 @@ PORTNAME= breeze-icons DISTVERSION= ${KDE_FRAMEWORKS_VERSION} +PORTREVISION= 1 CATEGORIES= x11-themes kde kde-frameworks MAINTAINER= kde@FreeBSD.org diff --git a/x11-themes/kf5-kemoticons/Makefile b/x11-themes/kf5-kemoticons/Makefile index cd1b4e11a5bf..09bda307ec20 100644 --- a/x11-themes/kf5-kemoticons/Makefile +++ b/x11-themes/kf5-kemoticons/Makefile @@ -2,6 +2,7 @@ PORTNAME= kemoticons DISTVERSION= ${KDE_FRAMEWORKS_VERSION} +PORTREVISION= 1 CATEGORIES= x11-themes kde kde-frameworks MAINTAINER= kde@FreeBSD.org diff --git a/x11-themes/kf5-kiconthemes/Makefile b/x11-themes/kf5-kiconthemes/Makefile index 7081ce57c34d..82a4a8785996 100644 --- a/x11-themes/kf5-kiconthemes/Makefile +++ b/x11-themes/kf5-kiconthemes/Makefile @@ -2,6 +2,7 @@ PORTNAME= kiconthemes DISTVERSION= ${KDE_FRAMEWORKS_VERSION} +PORTREVISION= 1 CATEGORIES= x11-themes kde kde-frameworks MAINTAINER= kde@FreeBSD.org diff --git a/x11-themes/kf5-oxygen-icons5/Makefile b/x11-themes/kf5-oxygen-icons5/Makefile index 03713ac805e9..b4dba52f2d4a 100644 --- a/x11-themes/kf5-oxygen-icons5/Makefile +++ b/x11-themes/kf5-oxygen-icons5/Makefile @@ -2,6 +2,7 @@ PORTNAME= oxygen-icons5 DISTVERSION= ${KDE_FRAMEWORKS_VERSION} +PORTREVISION= 1 CATEGORIES= x11-themes kde kde-frameworks MAINTAINER= kde@FreeBSD.org diff --git a/x11-themes/kf5-qqc2-desktop-style/Makefile b/x11-themes/kf5-qqc2-desktop-style/Makefile index 292ccc949d94..bb87a50162a3 100644 --- a/x11-themes/kf5-qqc2-desktop-style/Makefile +++ b/x11-themes/kf5-qqc2-desktop-style/Makefile @@ -2,6 +2,7 @@ PORTNAME= qqc2-desktop-style DISTVERSION= ${KDE_FRAMEWORKS_VERSION} +PORTREVISION= 1 CATEGORIES= x11-themes kde kde-frameworks MAINTAINER= kde@FreeBSD.org diff --git a/x11-themes/lumina-themes/Makefile b/x11-themes/lumina-themes/Makefile index 2f5ad2dd3db6..1b198e3825de 100644 --- a/x11-themes/lumina-themes/Makefile +++ b/x11-themes/lumina-themes/Makefile @@ -2,7 +2,7 @@ PORTNAME= lumina-themes PORTVERSION= 201710311100 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= x11-themes MAINTAINER= jt@ixsystems.com diff --git a/x11-themes/lxqt-themes/Makefile b/x11-themes/lxqt-themes/Makefile index b5f34a27bd09..d0a539064421 100644 --- a/x11-themes/lxqt-themes/Makefile +++ b/x11-themes/lxqt-themes/Makefile @@ -3,6 +3,7 @@ PORTNAME= lxqt-themes PORTVERSION= 0.13.0 +PORTREVISION= 1 CATEGORIES= x11-themes MASTER_SITES= LXQT diff --git a/x11-themes/plasma5-breeze-gtk/Makefile b/x11-themes/plasma5-breeze-gtk/Makefile index e801a7804d2a..f58c9b395d45 100644 --- a/x11-themes/plasma5-breeze-gtk/Makefile +++ b/x11-themes/plasma5-breeze-gtk/Makefile @@ -2,6 +2,7 @@ PORTNAME= breeze-gtk DISTVERSION= ${KDE_PLASMA_VERSION} +PORTREVISION= 1 CATEGORIES= x11-themes kde kde-plasma MAINTAINER= kde@FreeBSD.org diff --git a/x11-themes/plasma5-breeze/Makefile b/x11-themes/plasma5-breeze/Makefile index fe9cdbae5132..d041968de9db 100644 --- a/x11-themes/plasma5-breeze/Makefile +++ b/x11-themes/plasma5-breeze/Makefile @@ -2,6 +2,7 @@ PORTNAME= breeze DISTVERSION= ${KDE_PLASMA_VERSION} +PORTREVISION= 1 CATEGORIES= x11-themes kde kde-plasma MAINTAINER= kde@FreeBSD.org diff --git a/x11-themes/plasma5-kde-gtk-config/Makefile b/x11-themes/plasma5-kde-gtk-config/Makefile index e07f2698baae..3ab47092fdc0 100644 --- a/x11-themes/plasma5-kde-gtk-config/Makefile +++ b/x11-themes/plasma5-kde-gtk-config/Makefile @@ -2,6 +2,7 @@ PORTNAME= kde-gtk-config DISTVERSION= ${KDE_PLASMA_VERSION} +PORTREVISION= 1 CATEGORIES= x11-themes kde kde-plasma MAINTAINER= kde@FreeBSD.org diff --git a/x11-themes/plasma5-oxygen/Makefile b/x11-themes/plasma5-oxygen/Makefile index a47fa38799a5..3f30b54d3342 100644 --- a/x11-themes/plasma5-oxygen/Makefile +++ b/x11-themes/plasma5-oxygen/Makefile @@ -2,6 +2,7 @@ PORTNAME= oxygen DISTVERSION= ${KDE_PLASMA_VERSION} +PORTREVISION= 1 CATEGORIES= x11-themes kde kde-plasma MAINTAINER= kde@FreeBSD.org diff --git a/x11-themes/plasma5-plasma-workspace-wallpapers/Makefile b/x11-themes/plasma5-plasma-workspace-wallpapers/Makefile index 228433a60cc1..0fbeae2651f4 100644 --- a/x11-themes/plasma5-plasma-workspace-wallpapers/Makefile +++ b/x11-themes/plasma5-plasma-workspace-wallpapers/Makefile @@ -2,6 +2,7 @@ PORTNAME= plasma-workspace-wallpapers DISTVERSION= ${KDE_PLASMA_VERSION} +PORTREVISION= 1 CATEGORIES= x11-themes kde kde-plasma MAINTAINER= kde@FreeBSD.org diff --git a/x11-themes/qt5-style-plugins/Makefile b/x11-themes/qt5-style-plugins/Makefile index 9f8edd281250..86b8a05ce930 100644 --- a/x11-themes/qt5-style-plugins/Makefile +++ b/x11-themes/qt5-style-plugins/Makefile @@ -4,7 +4,7 @@ PORTNAME= qt5-style-plugins DISTVERSIONPREFIX= v DISTVERSION= 5.0.0-23 -PORTREVISION= 2 +PORTREVISION= 3 DISTVERSIONSUFFIX= -g335dbe CATEGORIES= x11-themes DIST_SUBDIR= KDE/Qt/addons diff --git a/x11-themes/qtcurve-kf5/Makefile b/x11-themes/qtcurve-kf5/Makefile index da17091dfb96..f50654a441eb 100644 --- a/x11-themes/qtcurve-kf5/Makefile +++ b/x11-themes/qtcurve-kf5/Makefile @@ -1,7 +1,7 @@ # $FreeBSD$ PORTNAME= qtcurve -PORTREVISION= 0 +PORTREVISION= 1 COMMENT= QtCurve KDE Frameworks 5 widget style and window decoration diff --git a/x11-themes/qtcurve-qt5/Makefile b/x11-themes/qtcurve-qt5/Makefile index 59c647847147..5516d5160712 100644 --- a/x11-themes/qtcurve-qt5/Makefile +++ b/x11-themes/qtcurve-qt5/Makefile @@ -1,7 +1,7 @@ # $FreeBSD$ PORTNAME= qtcurve -PORTREVISION= 0 +PORTREVISION= 1 COMMENT= QtCurve widget style for Qt 5 diff --git a/x11-themes/qtcurve/Makefile b/x11-themes/qtcurve/Makefile index 66315a765f1c..ac018c0d2657 100644 --- a/x11-themes/qtcurve/Makefile +++ b/x11-themes/qtcurve/Makefile @@ -2,7 +2,7 @@ PORTNAME= qtcurve DISTVERSION= 1.9.0-rc1 -PORTREVISION?= 3 +PORTREVISION?= 4 CATEGORIES= x11-themes MAINTAINER= jhale@FreeBSD.org diff --git a/x11-themes/xfce-evolution/Makefile b/x11-themes/xfce-evolution/Makefile index f3fbd863686a..a0e986188c1d 100644 --- a/x11-themes/xfce-evolution/Makefile +++ b/x11-themes/xfce-evolution/Makefile @@ -2,6 +2,7 @@ PORTNAME= xfce-evolution DISTVERSION= 5.6.2 +PORTREVISION= 1 CATEGORIES= x11-themes MASTER_SITES= SF/${PORTNAME} |