summaryrefslogtreecommitdiff
path: root/security/trousers/files/patch-0a14b979.c
diff options
context:
space:
mode:
authorNiclas Zeising <zeising@FreeBSD.org>2020-08-18 23:23:22 +0000
committerNiclas Zeising <zeising@FreeBSD.org>2020-08-18 23:23:22 +0000
commit7671dd5ccb2e735ec6bf154e8ac29fd98ae1483a (patch)
tree70b10b3799286e89cf97192ef35ce4d3cb033761 /security/trousers/files/patch-0a14b979.c
parentvuxml: Document security issues in security/trousers (diff)
security/trousers: fix security issues
Fix three security issues in security/trousers: * CVE-2020-24332 If the tcsd daemon is started with root privileges, the creation of the system.data file is prone to symlink attacks * CVE-2020-24330 If the tcsd daemon is started with root privileges, it fails to drop the root gid after it is no longer needed * CVE-2020-24331 If the tcsd daemon is started with root privileges, the tss user has read and write access to the /etc/tcsd.conf file Add patches to fix potential use-after-free Fix build with -fno-common MFH: 2020Q3 Security: e37a0a7b-e1a7-11ea-9538-0c9d925bbbc0
Notes
Notes: svn path=/head/; revision=545264
Diffstat (limited to 'security/trousers/files/patch-0a14b979.c')
-rw-r--r--security/trousers/files/patch-0a14b979.c25
1 files changed, 25 insertions, 0 deletions
diff --git a/security/trousers/files/patch-0a14b979.c b/security/trousers/files/patch-0a14b979.c
new file mode 100644
index 000000000000..b116c75f6dc9
--- /dev/null
+++ b/security/trousers/files/patch-0a14b979.c
@@ -0,0 +1,25 @@
+commit 0a14b979064052d3263054488602fba3bf97883b
+Author: Jerry Snitselaar <jsnitsel@redhat.com>
+Date: Wed Jan 16 14:00:43 2019 -0700
+
+ trousers: clean up use after free in Transport_TerminateHandle
+
+ Clean up possible use after free. The value of the handles pointer
+ may change, but if it doesn't then free is being called twice on
+ the same address.
+
+ Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
+ Signed-off-by: Debora Velarde Babb <debora@linux.ibm.com>
+
+diff --git src/tcs/tcs_evlog_imaem.c src/tcs/tcs_evlog_imaem.c
+index d158330..33af283 100644
+--- src/tcs/tcs_evlog_imaem.c
++++ src/tcs/tcs_evlog_imaem.c
+@@ -259,6 +259,7 @@ ima_get_entry(FILE *handle, UINT32 pcr_index, UINT32 *num, TSS_PCR_EVENT **ppEve
+ if (event->rgbPcrValue == NULL) {
+ LogError("malloc of %d bytes failed.", 20);
+ free(event);
++ event = NULL;
+ result = TCSERR(TSS_E_OUTOFMEMORY);
+ goto done;
+ }