- Unbreak the build on PowerPC by using correct Fif_ENTRYPOINT() macro that

  does not append double underscore to symbol names in binaries (previously
  __FreeBSD__ check was removed from the condition, but __PPC__ was left)
- Rename the patch: not only it used now deprecated `+' as path separator,
  the patch name itself was just wrong (inconsistent with the patched file)
- Remove useless PKGMESSAGE assignment, bsd.port.mk does this automatically
- Improve `regression-test' target: add dependency on `build', and get rid
  of explicit cd'ing to ${BUILD_WRKSRC} by using -C switch of make(1)
- Fix some minor whitespace bugs and reorder the knobs to make more sense

I've removed BROKEN statement entirely (for all Tier-2 systems) while I've
only tested it on PowerPC: it pulls quite heavy GCC 4.8 for Fortran support
and I didn't want to stress our poor flame too much (This is a really slow,
old machine. Be gentle).  Since the bug was indeed PowerPC-specific, it is
probably OK (and worth trying anyway).

1 files changed, 12 insertions, 0 deletions

diff --git a/science/cdf/files/patch-src_include_cdflib.h b/science/cdf/files/patch-src_include_cdflib.h
new file mode 100644
index 000000000000..2d5f0acc0b10
--- /dev/null
+++ b/science/cdf/files/patch-src_include_cdflib.h
@@ -0,0 +1,12 @@
+--- src/include/cdflib.h.orig	2010-01-18 15:22:03.000000000 -0600
++++ src/include/cdflib.h	2010-01-18 15:22:32.000000000 -0600
+@@ -375,8 +375,7 @@
+ #elif defined(unix) && !defined(AIX) && !defined(Mach) && !defined(hpux) || \
+     defined(__MINGW32__)
+ #  if (defined(linux) && !defined(__ICC)) || defined(__CYGWIN__) || \
+-      defined(sun) || defined(__MINGW32__) || defined(__FreeBSD__) || \
+-      defined(__PPC__)
++      defined(sun) || defined(__MINGW32__)
+ #    define Fif_ENTRYPOINT(ep__,ep_,ep,EP) ep__
+ #  else
+ #    define Fif_ENTRYPOINT(ep__,ep_,ep,EP) ep_