Convert net-im/libpurple (and slave ports net-im/finch and net-im/pidgin)

to "USES=libtool tar:bzip2".  Bump PORTREVISION on all dependent ports
and modernise them as well (USES, LIB_DEPENDS, staging).

audio/pidgin-musictracker:
- Replace LIBS with LDFLAGS.
- Disable static plugin.

net/online-desktop: Remove obsolete patches.

net-im/mbpurple:
- Drop pkgconf dependency.
- Replace post-patch with MAKE_ARGS.
- Use standard do-build.

net-im/pidgin-audacious-remote: Disable static plugin.

net-im/pidgin-birthday-reminder: Disable static plugin.

net-im/pidgin-fetion: Replace pkg-plist with PLIST_FILES.

net-im/pidgin-guifications:
- Drop USE_GNOME=gnomeprefix.
- Replace LIBS with LDFLAGS.

net-im/pidgin-hotkeys:
- Drop CFLAGS=-fPIC.
- Fix build on systems without gcc.

net-im/pidgin-libnotify:
- Use option helpers.
- Drop references to PTHREAD_CFLAGS and PTHREAD_LIBS.

net-im/pidgin-manualsize: Fix build on systems without gcc.

net-im/pidgin-privacy-please:
- Replace a patch with CPPFLAGS and LDFLAGS.
- Don't use USE_LDCONFIG for a plugin.

net-im/pidgin-sipe:
- Don't use USE_LDCONFIG for a plugin.
- Drop PORTDOCS that don't contain useful documentation.
- Patch configure with s/LDLAGS/LDFLAGS/ so LDFLAGS can replace LIBS.
- Use option helpers and fix Kerberos option.
- Remove obsolete CONFIGURE_ENV.

security/pidgin-encryption:
- Drop references to PTHREAD_CFLAGS and PTHREAD_LIBS.
- Disable static plugin.
- Use option helpers.

security/pidgin-otr:
- Drop redundant comment about PORTREVISION.
- Add USE_GNOME=gtk20.
- Drop references to PTHREAD_CFLAGS and PTHREAD_LIBS.
- Port uses stack protector unconditionally so link with -lssp_nonshared
  when necessary like Mk/bsd.ssp.mk does.

Approved by:	portmgr (PORTREVISION bump on unstaged port)

2 files changed, 4 insertions, 7 deletions

diff --git a/net-im/pidgin-guifications/Makefile b/net-im/pidgin-guifications/Makefile
index 649c702c27b8..1ad358054ce6 100644
--- a/net-im/pidgin-guifications/Makefile
+++ b/net-im/pidgin-guifications/Makefile
@@ -3,7 +3,7 @@
 
 PORTNAME=	pidgin-guifications
 PORTVERSION=	2.16
-PORTREVISION=	5
+PORTREVISION=	6
 CATEGORIES=	net-im
 MASTER_SITES=	https://www.mimar.rs/distfiles/
 
@@ -15,17 +15,15 @@ LICENSE=	GPLv2
 BUILD_DEPENDS=	${LOCALBASE}/include/pidgin/pidgin.h:${PORTSDIR}/net-im/pidgin
 RUN_DEPENDS=	pidgin:${PORTSDIR}/net-im/pidgin
 
-USE_BZIP2=	yes
-USES=		pathfix gettext gmake pkgconfig
-USE_GNOME=	gnomeprefix gtk20
+USES=		gettext gmake libtool pathfix pkgconfig tar:bzip2
+USE_GNOME=	gtk20
 GNU_CONFIGURE=	yes
-CONFIGURE_ENV=	LIBS="-L${LOCALBASE}/lib"
 CPPFLAGS+=	-I${LOCALBASE}/include
+LDFLAGS+=	-L${LOCALBASE}/lib
 
 post-extract:
 	@${FIND} ${WRKSRC} -name "Makefile.in" | ${XARGS} ${REINPLACE_CMD} \
 		-e 's#\([@(]\)PIDGIN_LIBDIR\([@)]\)#\1libdir\2#' \
 		-e 's#\([@(]\)PIDGIN_DATADIR\([@)]\)#\1datadir\2#'
-	@${REINPLACE_CMD} -e 's|echo aout|echo elf|' ${WRKSRC}/configure
 
 .include <bsd.port.mk>
diff --git a/net-im/pidgin-guifications/pkg-plist b/net-im/pidgin-guifications/pkg-plist
index dbd4d063962c..ae0e8abbdf65 100644
--- a/net-im/pidgin-guifications/pkg-plist
+++ b/net-im/pidgin-guifications/pkg-plist
@@ -1,4 +1,3 @@
-lib/pidgin/guifications.la
 lib/pidgin/guifications.so
 share/pixmaps/pidgin/guifications/conf/item_icon_size_big.png
 share/pixmaps/pidgin/guifications/conf/item_icon_size_huge.png