diff options
author | Tijl Coosemans <tijl@FreeBSD.org> | 2019-01-16 11:13:44 +0000 |
---|---|---|
committer | Tijl Coosemans <tijl@FreeBSD.org> | 2019-01-16 11:13:44 +0000 |
commit | 1bf487d3e73d83700f5a4aeb3a9ffbfc6e87856b (patch) | |
tree | 127ae6686665fd0ff97a7bd5f27449299929734e /editors | |
parent | Remove expired port: (diff) |
Fix Qt5 symbol version scripts to put the catch-all clause first. When
a symbol matches multiple clauses the last one takes precedence. If the
catch-all is last it captures everything. In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API. This only affects lld because GNU ld always gives the
catch-all lowest priority.
Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium. Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3] The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one. If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash. Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.
Remove the weak wrappers (make them Linux specific). This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.
[1] https://github.com/qt/qtwebengine/commit/5c2cbfccf9aafb547b0b30914c4056abd25942a4
[2] https://github.com/qt/qtwebengine/commit/2ed5054e3a800fa97c2c9e920ba1e6ea4b6ef2a5
[3] https://github.com/qt/qtwebengine/commit/009f5ebb4bd6e50188671e0815a5dae6afe39db5
Bump all ports that depend on Qt5.
PR: 234070
Exp-run by: antoine
Approved by: kde (adridg)
Notes
Notes:
svn path=/head/; revision=490472
Diffstat (limited to 'editors')
-rw-r--r-- | editors/calligra/Makefile | 2 | ||||
-rw-r--r-- | editors/calligraplan/Makefile | 2 | ||||
-rw-r--r-- | editors/dexed/Makefile | 1 | ||||
-rw-r--r-- | editors/encryptpad/Makefile | 2 | ||||
-rw-r--r-- | editors/featherpad/Makefile | 2 | ||||
-rw-r--r-- | editors/focuswriter/Makefile | 1 | ||||
-rw-r--r-- | editors/ghostwriter/Makefile | 2 | ||||
-rw-r--r-- | editors/kate/Makefile | 1 | ||||
-rw-r--r-- | editors/kile/Makefile | 1 | ||||
-rw-r--r-- | editors/lazarus-qt5/Makefile | 1 | ||||
-rw-r--r-- | editors/neovim-qt/Makefile | 1 | ||||
-rw-r--r-- | editors/picpas/Makefile | 1 | ||||
-rw-r--r-- | editors/tea/Makefile | 1 | ||||
-rw-r--r-- | editors/texmaker/Makefile | 2 | ||||
-rw-r--r-- | editors/texstudio/Makefile | 1 | ||||
-rw-r--r-- | editors/texworks/Makefile | 1 |
16 files changed, 16 insertions, 6 deletions
diff --git a/editors/calligra/Makefile b/editors/calligra/Makefile index 1d10db766a27..e625b16dff43 100644 --- a/editors/calligra/Makefile +++ b/editors/calligra/Makefile @@ -2,7 +2,7 @@ PORTNAME= calligra DISTVERSION= 3.1.0 -PORTREVISION= 9 +PORTREVISION= 10 CATEGORIES= editors kde MASTER_SITES= KDE/stable/${PORTNAME}/${PORTVERSION} DIST_SUBDIR= KDE/${PORTNAME} diff --git a/editors/calligraplan/Makefile b/editors/calligraplan/Makefile index 1f701e23c455..2084d50ffcff 100644 --- a/editors/calligraplan/Makefile +++ b/editors/calligraplan/Makefile @@ -2,7 +2,7 @@ PORTNAME= calligraplan DISTVERSION= 3.1.0 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= editors kde MASTER_SITES= KDE/stable/calligra/${PORTVERSION} DIST_SUBDIR= KDE/${PORTNAME} diff --git a/editors/dexed/Makefile b/editors/dexed/Makefile index 6585ff97ae66..8725a4e4c900 100644 --- a/editors/dexed/Makefile +++ b/editors/dexed/Makefile @@ -3,6 +3,7 @@ PORTNAME= dexed PORTVERSION= 3.6.21 DISTVERSIONPREFIX=v +PORTREVISION= 1 CATEGORIES= editors PKGNAMESUFFIX= ${LAZARUS_PKGNAMESUFFIX} diff --git a/editors/encryptpad/Makefile b/editors/encryptpad/Makefile index 67f8a08dfb17..ff2df90aefb8 100644 --- a/editors/encryptpad/Makefile +++ b/editors/encryptpad/Makefile @@ -4,7 +4,7 @@ PORTNAME= encryptpad DISTVERSIONPREFIX= v DISTVERSION= 0.4.0.4 -PORTREVISION= 2 +PORTREVISION= 3 CATEGORIES= editors security MAINTAINER= dg@syrec.org diff --git a/editors/featherpad/Makefile b/editors/featherpad/Makefile index 525d489da121..9c0aac585944 100644 --- a/editors/featherpad/Makefile +++ b/editors/featherpad/Makefile @@ -3,7 +3,7 @@ PORTNAME= featherpad PORTVERSION= 0.9.1 -PORTREVISION= 1 +PORTREVISION= 2 DISTVERSIONPREFIX= V CATEGORIES= editors diff --git a/editors/focuswriter/Makefile b/editors/focuswriter/Makefile index 792e59ae74f9..3370da538213 100644 --- a/editors/focuswriter/Makefile +++ b/editors/focuswriter/Makefile @@ -4,6 +4,7 @@ PORTNAME= focuswriter DISTVERSIONPREFIX= v DISTVERSION= 1.7.1 +PORTREVISION= 1 CATEGORIES= editors MAINTAINER= lightside@gmx.com diff --git a/editors/ghostwriter/Makefile b/editors/ghostwriter/Makefile index 934e1804cc62..13e93ef97918 100644 --- a/editors/ghostwriter/Makefile +++ b/editors/ghostwriter/Makefile @@ -3,7 +3,7 @@ PORTNAME= ghostwriter DISTVERSIONPREFIX= v DISTVERSION= 1.7.4 -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= editors MAINTAINER= tobik@FreeBSD.org diff --git a/editors/kate/Makefile b/editors/kate/Makefile index 2ba5b8203353..9777f208ac69 100644 --- a/editors/kate/Makefile +++ b/editors/kate/Makefile @@ -2,6 +2,7 @@ PORTNAME= kate DISTVERSION= ${KDE_APPLICATIONS_VERSION} +PORTREVISION= 1 CATEGORIES= editors kde kde-applications MAINTAINER= kde@FreeBSD.org diff --git a/editors/kile/Makefile b/editors/kile/Makefile index 399d170997b1..2ed76e80c5da 100644 --- a/editors/kile/Makefile +++ b/editors/kile/Makefile @@ -3,6 +3,7 @@ PORTNAME= kile DISTVERSIONPREFIX= v DISTVERSION= 3.0b2 +PORTREVISION= 1 CATEGORIES= editors kde MAINTAINER= kde@FreeBSD.org diff --git a/editors/lazarus-qt5/Makefile b/editors/lazarus-qt5/Makefile index db9720fa6cb3..3a509b6064bf 100644 --- a/editors/lazarus-qt5/Makefile +++ b/editors/lazarus-qt5/Makefile @@ -1,5 +1,6 @@ # $FreeBSD$ +PORTREVISION= 2 PKGNAMESUFFIX?= -qt5 COMMENT= Portable Delphi-like IDE for the FreePascal compiler (QT5) diff --git a/editors/neovim-qt/Makefile b/editors/neovim-qt/Makefile index 598b063b4aae..b3f664c60546 100644 --- a/editors/neovim-qt/Makefile +++ b/editors/neovim-qt/Makefile @@ -3,6 +3,7 @@ PORTNAME= neovim-qt DISTVERSIONPREFIX= v DISTVERSION= 0.2.10 +PORTREVISION= 1 CATEGORIES= editors MAINTAINER= chuck@tuffli.net diff --git a/editors/picpas/Makefile b/editors/picpas/Makefile index 0e401d971453..04d29799a961 100644 --- a/editors/picpas/Makefile +++ b/editors/picpas/Makefile @@ -3,6 +3,7 @@ PORTNAME= picpas PORTVERSION= 0.8.8 DISTVERSIONPREFIX= v +PORTREVISION= 1 CATEGORIES= editors PKGNAMESUFFIX= ${LAZARUS_PKGNAMESUFFIX} diff --git a/editors/tea/Makefile b/editors/tea/Makefile index ab1bf0b9aed2..8ab337012a70 100644 --- a/editors/tea/Makefile +++ b/editors/tea/Makefile @@ -3,6 +3,7 @@ PORTNAME= tea PORTVERSION= 47.0.1 +PORTREVISION= 1 CATEGORIES= editors MAINTAINER= danilo@FreeBSD.org diff --git a/editors/texmaker/Makefile b/editors/texmaker/Makefile index 7e0324146f87..59faed539263 100644 --- a/editors/texmaker/Makefile +++ b/editors/texmaker/Makefile @@ -3,7 +3,7 @@ PORTNAME= texmaker PORTVERSION= 4.5 -PORTREVISION= 11 +PORTREVISION= 12 PORTEPOCH= 3 CATEGORIES= editors MASTER_SITES= http://www.xm1math.net/texmaker/ diff --git a/editors/texstudio/Makefile b/editors/texstudio/Makefile index 98f773add93f..c41b84819551 100644 --- a/editors/texstudio/Makefile +++ b/editors/texstudio/Makefile @@ -2,6 +2,7 @@ PORTNAME= texstudio DISTVERSION= 2.12.14 +PORTREVISION= 1 CATEGORIES= editors MAINTAINER= abiliojr@gmail.com diff --git a/editors/texworks/Makefile b/editors/texworks/Makefile index d119930b93f6..67e461f78184 100644 --- a/editors/texworks/Makefile +++ b/editors/texworks/Makefile @@ -4,6 +4,7 @@ PORTNAME= texworks DISTVERSIONPREFIX= release- DISTVERSION= 0.6.2 +PORTREVISION= 1 CATEGORIES= editors MAINTAINER= hrs@FreeBSD.org |