diff options
| author | Dimitry Andric <dim@FreeBSD.org> | 2015-02-18 22:23:06 +0000 |
|---|---|---|
| committer | Dimitry Andric <dim@FreeBSD.org> | 2015-02-18 22:23:06 +0000 |
| commit | 739c18f83ece02d2ce1370ae365b32dc74d4d3a2 (patch) | |
| tree | 678bb13bf91385b57c4f5084354057511c56900f /devel/binutils/files/patch-gas_config_tc-arm.c | |
| parent | Update Code_Aster to 11.7.0-1, with its different tools. (diff) | |
Fix undefined behavior in gas/contrib/tc-arm.c's rotate_left() macro,
similar to https://svnweb.freebsd.org/base?view=revision&revision=274856
This fixes possible "invalid constant after fixup" errors from gas, when
it has been compiled with high levels of optimization.
Obtained from: binutils commit d840c081f8082e8b9e63fead5306643975a97bb3
PR: 197806
Approved by: maintainer (bapt)
Notes
Notes:
svn path=/head/; revision=379320
Diffstat (limited to 'devel/binutils/files/patch-gas_config_tc-arm.c')
| -rw-r--r-- | devel/binutils/files/patch-gas_config_tc-arm.c | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/devel/binutils/files/patch-gas_config_tc-arm.c b/devel/binutils/files/patch-gas_config_tc-arm.c new file mode 100644 index 000000000000..1c599ef88d54 --- /dev/null +++ b/devel/binutils/files/patch-gas_config_tc-arm.c @@ -0,0 +1,17 @@ +From d840c081f8082e8b9e63fead5306643975a97bb3 Mon Sep 17 00:00:00 2001 +From: Richard Earnshaw <Richard.Earnshaw@arm.com> +Date: Thu, 20 Nov 2014 17:02:47 +0000 +Subject: [PATCH] * config/tc-arm.c (rotate_left): Avoid undefined behaviour + when N = 0. + +--- gas/config/tc-arm.c.orig 2014-10-14 09:32:03.000000000 +0200 ++++ gas/config/tc-arm.c 2015-02-18 21:13:40.720573000 +0100 +@@ -7251,7 +7251,7 @@ + + /* Functions for operand encoding. ARM, then Thumb. */ + +-#define rotate_left(v, n) (v << n | v >> (32 - n)) ++#define rotate_left(v, n) (v << (n & 31) | v >> ((32 - n) & 31)) + + /* If VAL can be encoded in the immediate field of an ARM instruction, + return the encoded form. Otherwise, return FAIL. */ |