summaryrefslogtreecommitdiff
path: root/cad/py-cocotb
diff options
context:
space:
mode:
authorCharlie Li <vishwin@FreeBSD.org>2023-02-05 14:05:02 -0500
committerCharlie Li <vishwin@FreeBSD.org>2023-02-05 14:05:02 -0500
commitf5890bd3cbc66a805bfc04a1a45688b5a3e68c50 (patch)
tree8f4e947d1da22bfaec90165e3997cffcb0cac742 /cad/py-cocotb
parentMk/Uses/python.mk: Fix USE_PYTHON=pep517: always compile and install bytecode (diff)
Revert "Mk/Uses/python.mk: Fix USE_PYTHON=pep517: always compile and install bytecode"
Despite installer's default behaviour to compile and install bytecode, we are not doing so going forward at stage/package time. [0] During initial development and qualification of PEP-517 framework support, compiling and installing bytecode at stage/package time was considered, but was found problematic, fragile and ultimately unreliable, both currently and historically (with USE_PYTHON=distutils), due to our fixed plist requirement. While the living binary distribution format (wheel) specification [1] says to compile bytecode, that is in the pure Python package management context (pip, etc); nuance always exists when interacting with "system" package management. Additionally, "bytecode is an implementation detail of the CPython interpreter. No guarantees are made that bytecode will not be added, removed, or changed between versions of Python," thus "should not be considered to work across Python VMs or Python releases." [2] This is important to ensuring correctness for those ports specifying NO_ARCH. Instead of compiling and installing bytecode at stage/package time, there is a WIP, review D34739, that compiles and installs bytecode at install time instead, using triggers. The aforementioned build_fs_violations will be investigated. This reverts commit de6965254c3a007efcf697c3d455b54d2aeb2383. With hat: python Approved by: tcberner (mentor, portmgr) Reference: https://wiki.freebsd.org/Python/PEP-517 [0] https://packaging.python.org/en/latest/specifications/binary-distribution-format/ [1] https://docs.python.org/3/library/dis.html [2]
Diffstat (limited to 'cad/py-cocotb')
-rw-r--r--cad/py-cocotb/Makefile1
1 files changed, 0 insertions, 1 deletions
diff --git a/cad/py-cocotb/Makefile b/cad/py-cocotb/Makefile
index 028bba005c16..211f36f0ab29 100644
--- a/cad/py-cocotb/Makefile
+++ b/cad/py-cocotb/Makefile
@@ -1,7 +1,6 @@
PORTNAME= cocotb
DISTVERSIONPREFIX= v
DISTVERSION= 1.7.2
-PORTREVISION= 1
CATEGORIES= cad python
PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}