summaryrefslogtreecommitdiff
path: root/Mk/Scripts
diff options
context:
space:
mode:
authorMathieu Arnold <mat@FreeBSD.org>2018-06-01 16:20:45 +0000
committerMathieu Arnold <mat@FreeBSD.org>2018-06-01 16:20:45 +0000
commit2364943f9d8e1a8fe0fc3f2dbd5c53e5dccdbf10 (patch)
treeda5f26159c69c2ca81f755f6c4cbb2aeef2ab7f2 /Mk/Scripts
parentSC2091: Remove surrounding $() to avoid executing output. (diff)
SC2153: Possible misspelling: PORTNAME may not be assigned, but portname is.
ShellCheck has noticed that you reference a variable that is not assigned in the script, which has a name remarkably similar to one that is explicitly assigned. You should verify that the variable name is spelled correctly. PR: 227109 Submitted by: mat Sponsored by: Absolight
Notes
Notes: svn path=/head/; revision=471271
Diffstat (limited to 'Mk/Scripts')
-rw-r--r--Mk/Scripts/qa.sh3
1 files changed, 3 insertions, 0 deletions
diff --git a/Mk/Scripts/qa.sh b/Mk/Scripts/qa.sh
index 2971f88092eb..b36dce8e5d3a 100644
--- a/Mk/Scripts/qa.sh
+++ b/Mk/Scripts/qa.sh
@@ -818,6 +818,9 @@ gemdeps()
{
rc=0
if [ "${PKGBASE%%-*}" = "rubygem" ]; then
+ # shellcheck disable=SC2153
+ # In the heredoc, ${PORTNAME} comes from the environment, not
+ # to be confused with ${portname}
while read -r l; do
if [ -n "${l}" ]; then
name=${l%% *}