Update dovecot to 2.2.29, and bump PORTREVISION for the plugins. Add a

warning to the pkg-message that security.bsd.see_other_uids/gids should
not be enabled if dovecot is storing mail for multiple users concurrently
(PR 218392, submitted by topical).

 * passdb/userdb dict: Don't double-expand %variables in keys. If dict
   was used as the authentication passdb, using specially crafted
   %variables in the username could be used to cause DoS (CVE-2017-2669)
 * When Dovecot encounters an internal error, it logs the real error and
   usually logs another line saying what function failed. Previously the
   second log line's error message was a rather uninformative "Internal
   error occurred. Refer to server log for more information." Now the
   real error message is duplicated in this second log line.
 * lmtp: If a delivery has multiple recipients, run autoexpunging only
   for the last recipient. This avoids a problem where a long
   autoexpunge run causes LMTP client to timeout between the DATA
   replies, resulting in duplicate mail deliveries.
 * config: Don't stop the process due to idling. Otherwise the
   configuration is reloaded when the process restarts.
 * mail_log plugin: Differentiate autoexpunges from regular expunges
 * imapc: Use LOGOUT to cleanly disconnect from server.
 * lib-http: Internal status codes (>9000) are no longer visible in logs
 * director: Log vhost count changes and HOST-UP/DOWN

 + quota: Add plugin { quota_max_mail_size } setting to limit the
   maximum individual mail size that can be saved.
 + imapc: Add imapc_features=delay-login. If set, connecting to the
   remote IMAP server isn't done until it's necessary.
 + imapc: Add imapc_connection_retry_count and
   imapc_connection_retry_interval settings.
 + imap, pop3, indexer-worker: Add (deinit) to process title before
   autoexpunging runs.
 + Added %{encrypt} and %{decrypt} variables
 + imap/pop3 proxy: Log proxy state in errors as human-readable string.
 + imap/pop3-login: All forward_* extra fields returned by passdb are
   sent to the next hop when proxying using ID/XCLIENT commands. On the
   receiving side these fields are imported and sent to auth process
   where they're accessible via %{passdb:forward_*}. This is done only
   if the sending IP address matches login_trusted_networks.
 + imap-login: If imap_id_retain=yes, send the IMAP ID string to
   auth process. %{client_id} expands to it in auth process. The ID
   string is also sent to the next hop when proxying.
 + passdb imap: Use ssl_client_ca_* settings for CA validation.
 - fts-tika: Fixed crash when parsing attachment without
   Content-Disposition header. Broken by 2.2.28. (fixed in FreeBSD ports)
 - trash plugin was broken in 2.2.28 (fixed in FreeBSD ports)
 - auth: When passdb/userdb lookups were done via auth-workers, too much
   data was added to auth cache. This could have resulted in wrong
   replies when using multiple passdbs/userdbs.
 - auth: passdb { skip & mechanisms } were ignored for the first passdb
 - oauth2: Various fixes, including fixes to crashes
 - dsync: Large Sieve scripts (or other large metadata) weren't always
   synced.
 - Index rebuild (e.g. doveadm force-resync) set all mails as \Recent
 - imap-hibernate: %{userdb:*} wasn't expanded in mail_log_prefix
 - doveadm: Exit codes weren't preserved when proxying commands via
   doveadm-server. Almost all errors used exit code 75 (tempfail).
 - ACLs weren't applied to not-yet-existing autocreated mailboxes.
 - Fixed a potential crash when parsing a broken message header.
 - cassandra: Fallback consistency settings weren't working correctly.
 - doveadm director status <user>: "Initial config" was always empty
 - imapc: Various reconnection fixes.

3 files changed, 8 insertions, 78 deletions

diff --git a/mail/dovecot2/files/patch-src_plugins_fts_fts-parser-tika.c b/mail/dovecot2/files/patch-src_plugins_fts_fts-parser-tika.c
deleted file mode 100644
index 8a7404ea54ff..000000000000
--- a/mail/dovecot2/files/patch-src_plugins_fts_fts-parser-tika.c
+++ /dev/null
@@ -1,30 +0,0 @@
-From 3751b61dfbc6c141731a740d982fc59918db2482 Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?Martti=20Rannanj=C3=A4rvi?= <martti.rannanjarvi@dovecot.fi>
-Date: Wed, 1 Mar 2017 12:29:17 +0200
-Subject: [PATCH] fts: Don't add NULL content disposition or type to HTTP
- header
-
----
- src/plugins/fts/fts-parser-tika.c | 9 ++++++---
- 1 file changed, 6 insertions(+), 3 deletions(-)
-
-diff --git a/src/plugins/fts/fts-parser-tika.c b/src/plugins/fts/fts-parser-tika.c
-index 8457f28..385f1d0 100644
---- src/plugins/fts/fts-parser-tika.c
-+++ src/plugins/fts/fts-parser-tika.c
-@@ -158,9 +158,12 @@ fts_parser_tika_try_init(struct mail_user *user, const char *content_type,
- 			fts_tika_parser_response, parser);
- 	http_client_request_set_port(http_req, http_url->port);
- 	http_client_request_set_ssl(http_req, http_url->have_ssl);
--	http_client_request_add_header(http_req, "Content-Type", content_type);
--	http_client_request_add_header(http_req, "Content-Disposition",
--				       content_disposition);
-+	if (content_type != NULL)
-+		http_client_request_add_header(http_req, "Content-Type",
-+					       content_type);
-+	if (content_disposition != NULL)
-+		http_client_request_add_header(http_req, "Content-Disposition",
-+					       content_disposition);
- 	http_client_request_add_header(http_req, "Accept", "text/plain");
- 
- 	parser->http_req = http_req;
diff --git a/mail/dovecot2/files/patch-trash_plugin b/mail/dovecot2/files/patch-trash_plugin
deleted file mode 100644
index 065d3d06f847..000000000000
--- a/mail/dovecot2/files/patch-trash_plugin
+++ /dev/null
@@ -1,48 +0,0 @@
-From 326fb016a23480e4ff8dcc03dc80e76812859bd6 Mon Sep 17 00:00:00 2001
-From: Aki Tuomi <aki.tuomi@dovecot.fi>
-Date: Wed, 1 Mar 2017 09:15:29 +0200
-Subject: [PATCH] trash: Read settings after namespaces are loaded
-
-Fixes Panic: file mail-namespace.c: line 709 (mail_namespace_find): assertion failed: (ns != NULL)
----
- src/plugins/trash/trash-plugin.c | 22 ++++++++++++++++------
- 1 file changed, 16 insertions(+), 6 deletions(-)
-
-diff --git a/src/plugins/trash/trash-plugin.c b/src/plugins/trash/trash-plugin.c
-index 7129d3d..2e12578 100644
---- src/plugins/trash/trash-plugin.c
-+++ src/plugins/trash/trash-plugin.c
-@@ -348,17 +348,27 @@ trash_mail_user_created(struct mail_user *user)
- 	} else {
- 		tuser = p_new(user->pool, struct trash_user, 1);
- 		MODULE_CONTEXT_SET(user, trash_user_module, tuser);
-+	}
-+}
- 
--		if (read_configuration(user, env) == 0) {
--			trash_next_quota_test_alloc =
--				quser->quota->set->test_alloc;
--			quser->quota->set->test_alloc = trash_quota_test_alloc;
--		}
-+static void
-+trash_mail_namespaces_created(struct mail_namespace *namespaces)
-+{
-+	struct mail_user *user = namespaces->user;
-+	struct trash_user *tuser = TRASH_USER_CONTEXT(user);
-+	struct quota_user *quser = QUOTA_USER_CONTEXT(user);
-+	const char *env = mail_user_plugin_getenv(user, "trash");
-+
-+	if (tuser != NULL && read_configuration(user, env) == 0) {
-+		trash_next_quota_test_alloc =
-+			quser->quota->set->test_alloc;
-+		quser->quota->set->test_alloc = trash_quota_test_alloc;
- 	}
- }
- 
- static struct mail_storage_hooks trash_mail_storage_hooks = {
--	.mail_user_created = trash_mail_user_created
-+	.mail_user_created = trash_mail_user_created,
-+	.mail_namespaces_created = trash_mail_namespaces_created,
- };
- 
- void trash_plugin_init(struct module *module)
diff --git a/mail/dovecot2/files/pkg-message.in b/mail/dovecot2/files/pkg-message.in
index ea7220eae149..1c57ad162d81 100644
--- a/mail/dovecot2/files/pkg-message.in
+++ b/mail/dovecot2/files/pkg-message.in
@@ -15,6 +15,14 @@
  	dovecot_enable="YES"
 
 
+---------------------------------------------------------------------
+
+To avoid a risk of mailbox corruption, do not enable the
+security.bsd.see_other_uids or .see_other_guids sysctls if Dovecot
+is storing mail for multiple concurrent users (PR 218392).
+
+---------------------------------------------------------------------
+
  If you want to be able to search within attachments using the
  decode2text plugin, you'll need to install textproc/catdoc, and
  one of graphics/xpdf or graphics/poppler-utils.