Fix Qt5 symbol version scripts to put the catch-all clause first. When

a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] https://github.com/qt/qtwebengine/commit/5c2cbfccf9aafb547b0b30914c4056abd25942a4
[2] https://github.com/qt/qtwebengine/commit/2ed5054e3a800fa97c2c9e920ba1e6ea4b6ef2a5
[3] https://github.com/qt/qtwebengine/commit/009f5ebb4bd6e50188671e0815a5dae6afe39db5

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)

18 files changed, 22 insertions, 7 deletions

diff --git a/databases/akonadi/Makefile b/databases/akonadi/Makefile
index 6c46752317e6..3cd5b1a615ef 100644
--- a/databases/akonadi/Makefile
+++ b/databases/akonadi/Makefile
@@ -2,6 +2,7 @@
 
 PORTNAME=	akonadi
 DISTVERSION=	${KDE_APPLICATIONS_VERSION}
+PORTREVISION=	1
 CATEGORIES=	databases kde kde-applications
 
 MAINTAINER=	kde@FreeBSD.org
diff --git a/databases/kbibtex/Makefile b/databases/kbibtex/Makefile
index 61dcceb20991..d2b145eb40bb 100644
--- a/databases/kbibtex/Makefile
+++ b/databases/kbibtex/Makefile
@@ -3,6 +3,7 @@
 
 PORTNAME=	kbibtex
 DISTVERSION=	0.8.2
+PORTREVISION=	1
 CATEGORIES=	databases kde
 MASTER_SITES=	KDE/stable/KBibTeX/${DISTVERSION}/
 
diff --git a/databases/kdb/Makefile b/databases/kdb/Makefile
index 1ad6f545ba5f..6dfa0c1c5c62 100644
--- a/databases/kdb/Makefile
+++ b/databases/kdb/Makefile
@@ -2,7 +2,7 @@
 
 PORTNAME=		kdb
 DISTVERSION=		3.1.0
-PORTREVISION=		3
+PORTREVISION=	4
 CATEGORIES=		databases kde
 MASTER_SITES=		KDE/stable/${PORTNAME}/src
 DIST_SUBDIR=		KDE/${PORTNAME}
diff --git a/databases/kexi/Makefile b/databases/kexi/Makefile
index 51412ce3e593..8ec396fce5a4 100644
--- a/databases/kexi/Makefile
+++ b/databases/kexi/Makefile
@@ -2,7 +2,7 @@
 
 PORTNAME=		kexi
 DISTVERSION=		3.1.0
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=		databases kde
 MASTER_SITES=		KDE/stable/${PORTNAME}/src
 DIST_SUBDIR=		KDE/${PORTNAME}
diff --git a/databases/opendbviewer/Makefile b/databases/opendbviewer/Makefile
index 4930d610e0b0..95104fe60dfd 100644
--- a/databases/opendbviewer/Makefile
+++ b/databases/opendbviewer/Makefile
@@ -2,7 +2,7 @@
 
 PORTNAME=	opendbviewer
 PORTVERSION=	1.1.0
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	databases
 
 MAINTAINER=	lbartoletti@tuxfamily.org
diff --git a/databases/pgmodeler/Makefile b/databases/pgmodeler/Makefile
index b8d34ec64343..f2db66ffb572 100644
--- a/databases/pgmodeler/Makefile
+++ b/databases/pgmodeler/Makefile
@@ -3,7 +3,7 @@
 
 PORTNAME=	pgmodeler
 PORTVERSION=	0.9.1
-PORTREVISION=	2
+PORTREVISION=	3
 DISTVERSIONPREFIX=	v
 CATEGORIES=	databases
 
diff --git a/databases/py-qt5-sql/Makefile b/databases/py-qt5-sql/Makefile
index c59af1d7a528..aa04af88ed30 100644
--- a/databases/py-qt5-sql/Makefile
+++ b/databases/py-qt5-sql/Makefile
@@ -1,6 +1,7 @@
 # $FreeBSD$
 
 PORTNAME=	sql
+PORTREVISION=	1
 CATEGORIES=	databases devel python
 
 MAINTAINER=	kde@FreeBSD.org
diff --git a/databases/qt5-sql/Makefile b/databases/qt5-sql/Makefile
index 20fbabb5da23..9a2586e67ec1 100644
--- a/databases/qt5-sql/Makefile
+++ b/databases/qt5-sql/Makefile
@@ -2,7 +2,7 @@
 
 PORTNAME=	sql
 DISTVERSION=	${QT5_VERSION}
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	databases
 PKGNAMEPREFIX=	qt5-
 
diff --git a/databases/qt5-sqldrivers-ibase/Makefile b/databases/qt5-sqldrivers-ibase/Makefile
index 4e833adb9193..2d18bc877641 100644
--- a/databases/qt5-sqldrivers-ibase/Makefile
+++ b/databases/qt5-sqldrivers-ibase/Makefile
@@ -1,5 +1,6 @@
 # $FreeBSD$
 
+PORTREVISION=	1
 
 DB=		IBase
 DB_DESC=	InterBase/Firebird
diff --git a/databases/qt5-sqldrivers-mysql/Makefile b/databases/qt5-sqldrivers-mysql/Makefile
index 2a646204e68e..b364a2bdf27b 100644
--- a/databases/qt5-sqldrivers-mysql/Makefile
+++ b/databases/qt5-sqldrivers-mysql/Makefile
@@ -1,5 +1,7 @@
 # $FreeBSD$
 
+PORTREVISION=	1
+
 DB=		MYSQL
 DB_DESC=	MySQL
 
diff --git a/databases/qt5-sqldrivers-odbc/Makefile b/databases/qt5-sqldrivers-odbc/Makefile
index 86e5798e1c14..8ac684b15e6d 100644
--- a/databases/qt5-sqldrivers-odbc/Makefile
+++ b/databases/qt5-sqldrivers-odbc/Makefile
@@ -1,5 +1,7 @@
 # $FreeBSD$
 
+PORTREVISION=	1
+
 COMMENT=	Qt ${DB_DESC} plugin
 
 DB=		ODBC
diff --git a/databases/qt5-sqldrivers-pgsql/Makefile b/databases/qt5-sqldrivers-pgsql/Makefile
index bf7cb5bdaa22..0ebab3535a77 100644
--- a/databases/qt5-sqldrivers-pgsql/Makefile
+++ b/databases/qt5-sqldrivers-pgsql/Makefile
@@ -1,6 +1,7 @@
 # $FreeBSD$
 
 PORTNAME=	pgsql
+PORTREVISION=	1
 
 DB=		PSQL
 DB_DESC=	PostgreSQL
diff --git a/databases/qt5-sqldrivers-sqlite2/Makefile b/databases/qt5-sqldrivers-sqlite2/Makefile
index 5a4de2e81df6..aead3727c8bf 100644
--- a/databases/qt5-sqldrivers-sqlite2/Makefile
+++ b/databases/qt5-sqldrivers-sqlite2/Makefile
@@ -1,5 +1,7 @@
 # $FreeBSD$
 
+PORTREVISION=	1
+
 DB=		SQLite2
 DB_DESC=	SQLite 2
 
diff --git a/databases/qt5-sqldrivers-sqlite3/Makefile b/databases/qt5-sqldrivers-sqlite3/Makefile
index 6a8554bce8f4..2a805747e5e2 100644
--- a/databases/qt5-sqldrivers-sqlite3/Makefile
+++ b/databases/qt5-sqldrivers-sqlite3/Makefile
@@ -1,6 +1,7 @@
 # $FreeBSD$
 
 PORTNAME=	sqlite3
+PORTREVISION=	1
 
 DB=		SQLite
 DB_DESC=	SQLite 3
diff --git a/databases/qt5-sqldrivers-tds/Makefile b/databases/qt5-sqldrivers-tds/Makefile
index 9a5b223c21c2..f2953412a270 100644
--- a/databases/qt5-sqldrivers-tds/Makefile
+++ b/databases/qt5-sqldrivers-tds/Makefile
@@ -1,5 +1,7 @@
 # $FreeBSD$
 
+PORTREVISION=	1
+
 DB=		TDS
 DB_DESC=	TDS Database Connectivity
 
diff --git a/databases/redisdesktopmanager/Makefile b/databases/redisdesktopmanager/Makefile
index 06e8752a4397..04648805cab3 100644
--- a/databases/redisdesktopmanager/Makefile
+++ b/databases/redisdesktopmanager/Makefile
@@ -2,6 +2,7 @@
 
 PORTNAME=	redisdesktopmanager
 PORTVERSION=	0.9.9
+PORTREVISION=	1
 CATEGORIES=	databases
 
 MAINTAINER=	swills@FreeBSD.org
diff --git a/databases/sqlitebrowser/Makefile b/databases/sqlitebrowser/Makefile
index c07e2ff682de..5e1f448540bf 100644
--- a/databases/sqlitebrowser/Makefile
+++ b/databases/sqlitebrowser/Makefile
@@ -3,7 +3,7 @@
 
 PORTNAME=	sqlitebrowser
 PORTVERSION=	3.10.1
-PORTREVISION=	2
+PORTREVISION=	3
 DISTVERSIONPREFIX=	v
 CATEGORIES=	databases
 
diff --git a/databases/sqlitestudio/Makefile b/databases/sqlitestudio/Makefile
index 9fcfb21ef141..c70321a509ae 100644
--- a/databases/sqlitestudio/Makefile
+++ b/databases/sqlitestudio/Makefile
@@ -3,7 +3,7 @@
 
 PORTNAME=	sqlitestudio
 DISTVERSION=	3.2.1
-PORTREVISION=	2
+PORTREVISION=	3
 CATEGORIES=	databases
 MASTER_SITES=	http://sqlitestudio.pl/files/sqlitestudio3/complete/tar/