diff options
| author | Badlop <badlop@process-one.net> | 2012-08-27 17:40:01 +0200 |
|---|---|---|
| committer | Badlop <badlop@process-one.net> | 2012-08-27 17:40:01 +0200 |
| commit | 2dc2769c92c9f268bb475fb11a1937228c4eb61e (patch) | |
| tree | fff8f6f688cc0965b52331c9acf1d65a68206369 | |
| parent | Add SCRAM and remove MD5 support to ejabberd commands auth verification (diff) | |
Log IP address when auth attempt fails (thanks to Zach Calvert)
| -rw-r--r-- | src/ejabberd_c2s.erl | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/src/ejabberd_c2s.erl b/src/ejabberd_c2s.erl index 552aa6dbb..62856887c 100644 --- a/src/ejabberd_c2s.erl +++ b/src/ejabberd_c2s.erl @@ -556,10 +556,11 @@ wait_for_auth({xmlstreamelement, El}, StateData) -> fsm_next_state_pack(session_established, NewStateData); _ -> + IP = peerip(StateData#state.sockmod, StateData#state.socket), ?INFO_MSG( - "(~w) Failed legacy authentication for ~s", + "(~w) Failed legacy authentication for ~s from IP ~s (~w)", [StateData#state.socket, - jlib:jid_to_string(JID)]), + jlib:jid_to_string(JID), jlib:ip_to_list(IP), IP]), Err = jlib:make_error_reply( El, ?ERR_NOT_AUTHORIZED), send_element(StateData, Err), @@ -646,10 +647,11 @@ wait_for_feature_request({xmlstreamelement, El}, StateData) -> StateData#state{ sasl_state = NewSASLState}); {error, Error, Username} -> + IP = peerip(StateData#state.sockmod, StateData#state.socket), ?INFO_MSG( - "(~w) Failed authentication for ~s@~s", + "(~w) Failed authentication for ~s@~s from IP ~s (~w)", [StateData#state.socket, - Username, StateData#state.server]), + Username, StateData#state.server, jlib:ip_to_list(IP), IP]), send_element(StateData, {xmlelement, "failure", [{"xmlns", ?NS_SASL}], @@ -799,10 +801,11 @@ wait_for_sasl_response({xmlstreamelement, El}, StateData) -> fsm_next_state(wait_for_sasl_response, StateData#state{sasl_state = NewSASLState}); {error, Error, Username} -> + IP = peerip(StateData#state.sockmod, StateData#state.socket), ?INFO_MSG( - "(~w) Failed authentication for ~s@~s", + "(~w) Failed authentication for ~s@~s from IP ~s (~w)", [StateData#state.socket, - Username, StateData#state.server]), + Username, StateData#state.server, jlib:ip_to_list(IP), IP]), send_element(StateData, {xmlelement, "failure", [{"xmlns", ?NS_SASL}], |