| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After a recent devel/readline update, net/samba416 fails to compile with
clang 19, resulting in errors similar to:
../../libcli/smbreadline/smbreadline.c:139:38: warning: 'CPPFunction' is deprecated [-Wdeprecated-declarations]
139 | rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn;
| ^
../../lib/replace/system/readline.h:50:31: note: expanded from macro 'RL_COMPLETION_CAST'
50 | # define RL_COMPLETION_CAST (CPPFunction *)
| ^
/usr/local/include/readline/rltypedefs.h:38:50: note: 'CPPFunction' has been explicitly marked deprecated here
38 | typedef char **CPPFunction (void) __attribute__((deprecated));
| ^
../../libcli/smbreadline/smbreadline.c:139:36: error: incompatible function pointer types assigning to 'rl_completion_func_t *' (aka 'char **(*)(const char *, int, int)') from 'CPPFunction *' (aka 'char **(*)(void)') [-Wincompatible-function-pointer-types]
139 | rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn;
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
There are two reasons: samba checks for `rl_completion_t`, while the
actual readline type is `rl_completion_func_t`, and samba's wrapper
`readline.h` header prefers the `CPPFunction` type which is deprecated,
while it should use `rl_completion_func_t` instead.
Fix the `wscript_configure` check to detect `rl_completion_func_t`, and
reverse the `HAVE_RL_COMPLETION_T` and `HAVE_CPPFUNCTION` checks in the
wrapper header.
PR: 281817
Approved by: samba (0mp)
Reviewed by: 0mp
MFH: 2024Q3
|
| |
|
|
|
|
| |
PR: 275343
Approved by: maintainer timeout (6 months)
Approved by: mikael (samba419 maintainer, ports committer)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update a call to memcpy() because readdir() only guarantees memory up to
result+result->d_reclen is readable. Under certain conditions,
result+sizeof(struct dirent) landed in unmapped memory.
Most of the legwork to pinpoint the problem, as well as a solution
similar to the one applied here, was submitted by uratan@miomio.jp.
Martin Simmons <martin@lispworks.com> contributed to understanding the
problem and wrote a useful test case.
PR: 275597
Approved by: maintainer timeout
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D43171
|
| |
|
|
|
|
|
|
|
| |
vulnerabilities.
Security: CVE-2022-38023
CVE-2022-37966
CVE-2022-37967
CVE-2022-45141
|
| |
|
|
| |
Security: CVE-2022-42898
|
| |
|
|
|
| |
PR: 267141
Security: CVE-2022-3437
|
|
|
This is an initial attempt to add Samba to the FreeBSD after major
rewrite of the VFS code in the upstream.
Most of the port development is now carried in:
https://gitlab.com/samba-freebsd
Due to the way how new Samba VFS code is written there is a constrain
that Samba 4.14+ can run only on FreeBSD 13.1+, as it requires support
of the `nodup` option for the `fdesc` file system, as well as it's
presence in the system in general.
https://gitlab.com/samba-freebsd/-/wikis/The-New-VFS
I'd like to thank CyberSecure Pty Ltd. company for their supoort of
the port development and Andrew Walker from iXsystems Inc. for the
patches he created and made available for the Samba4 on TrueNAS.
PR: 263874
|
