diff options
| author | Emanuel Haupt <ehaupt@FreeBSD.org> | 2015-07-09 05:47:32 +0000 |
|---|---|---|
| committer | Emanuel Haupt <ehaupt@FreeBSD.org> | 2015-07-09 05:47:32 +0000 |
| commit | 72451773c83da13d33a2aa0249d3dec1a9f0fef0 (patch) | |
| tree | 6107aef88d00870440839ac4e0635f3ebe9859c8 /shells | |
| parent | Upgrade to version 0.4.0. (diff) | |
Scripts like https://github.com/henricj/scripts/blob/master/stir.sh often
generate a bunch of,
cannot make pipe for process substitution: File exists
errors.
The problem lies with colliding pipe names.
The code in sh_mktmpname() in lib/sh/tmpfile.c uses a combination of things like
the current time, the PID, and an incrementing counter. Since the child PIDs
tend to be sequential (barring kern.randompid=1), there are collisions.
Fix this problem without rewriting upstream code by defining USE_MKTEMP=1 to
use the mktemp(3) code of bash.
FreeBSD's mktemp() is not nearly as bad as the bash default and isn't
brain-damaged like some platforms (which is likely why the bash code tries to
do it's own thing). In FreeBSD, "mktemp(3)" it uses arc4random to pick one of
62 symbols for each "X".
Submitted by: Henric Jungheim <software@henric.org>
Notes
Notes:
svn path=/head/; revision=391614
Diffstat (limited to 'shells')
| -rw-r--r-- | shells/bash/Makefile | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/shells/bash/Makefile b/shells/bash/Makefile index d7f093b5d92b..c1cee5f376bc 100644 --- a/shells/bash/Makefile +++ b/shells/bash/Makefile @@ -4,7 +4,7 @@ PORTNAME= bash PATCHLEVEL= 39 PORTVERSION= 4.3.${PATCHLEVEL:S/^0//g} -PORTREVISION?= 0 +PORTREVISION?= 1 CATEGORIES= shells MASTER_SITES= GNU/${PORTNAME} DISTNAME= ${PORTNAME}-${PORTVERSION:R} @@ -54,6 +54,8 @@ CONFIGURE_ARGS+= --without-bash-malloc \ --disable-rpath \ --enable-disabled-builtins +CFLAGS+= -DUSE_MKTEMP=1 + .if empty(PKGNAMESUFFIX) CONFLICTS+= bash-static-[0-9]* .else |