Instead of marking this port FORBIDDEN, show a security warning and ask

if the user wants to proceed (unless BATCH is set) at pre-fetch and
pre-install.  Make the same query at pkg_add time.

While I'm at it,
- Move the URI to DESCR from Makefile.
- Replace a few = with ?=
- Instead of using echo in Makefile to create the sample startup
  script, use a template.

4 files changed, 47 insertions, 14 deletions

diff --git a/mail/youbin/Makefile b/mail/youbin/Makefile
index f126895527be..6436c0c1f270 100644
--- a/mail/youbin/Makefile
+++ b/mail/youbin/Makefile
@@ -1,5 +1,4 @@
 # New ports collection makefile for:	youbin
-# http://www.agusa.nuie.nagoya-u.ac.jp/software/youbin/youbin-e.html
 # Version required:		2.13
 # Date created:			09 Aug 1996
 # Whom:				Masafumi NAKANE <max@FreeBSD.org>
@@ -16,11 +15,9 @@ MAINTAINER=	max@FreeBSD.org
 
 LIB_DEPENDS=	Xpm.4:${PORTSDIR}/graphics/xpm
 
-FORBIDDEN=	see PR# 6180 about exploitable security hole
-
 USE_IMAKE=	yes
-PREFIX=         ${LOCALBASE}
-MTREE_FILE=	/etc/mtree/BSD.local.dist
+PREFIX?=         ${LOCALBASE}
+MTREE_FILE?=	/etc/mtree/BSD.local.dist
 
 MAN1=		youbin.1
 MAN3=		youbin_sub.3
@@ -28,16 +25,18 @@ MAN8=		youbind.8
 
 STARTUP_SCRIPT=	${PREFIX}/etc/rc.d/youbind.sh.sample
 
+pre-fetch:
+	@${SETENV} ${SCRIPTS_ENV} ${SH} ${PKGDIR}/REQ ${PKGNAME} BUILD
+
+pre-install:
+	@${SETENV} ${SCRIPTS_ENV} ${SH} ${PKGDIR}/REQ ${PKGNAME} INSTALL
+
 post-install:
-	@if [ ! -f ${STARTUP_SCRIPT} ]; then				\
+	@if [ ! -f ${STARTUP_SCRIPT} ]; then \
 		${ECHO} "Creating startup script '${STARTUP_SCRIPT}'" ;	\
-		${ECHO} "#!/bin/sh" > ${STARTUP_SCRIPT} ;			\
-		${ECHO} "if [ -f ${PREFIX}/sbin/youbind ]; then"		\
-			>> ${STARTUP_SCRIPT} ;				\
-		${ECHO} "    ${PREFIX}/sbin/youbind ; ${ECHO} -n ' youbind'"	\
-			>> ${STARTUP_SCRIPT} ;				\
-		${ECHO} "fi" >> ${STARTUP_SCRIPT} ;			\
-		${CHMOD} 755 ${STARTUP_SCRIPT} ;				\
+		${SED} s:@PREFIX@:${PREFIX}: ${FILESDIR}/youbind.sh.sample \
+		  > ${STARTUP_SCRIPT} ; \
+		${CHMOD} 755 ${STARTUP_SCRIPT} ; \
 	fi
 	@${SETENV} PKG_PREFIX=${PREFIX} ${SH} ${PKGDIR}/INSTALL ${PKGNAME} POST-INSTALL
 
diff --git a/mail/youbin/files/youbind.sh.sample b/mail/youbin/files/youbind.sh.sample
new file mode 100644
index 000000000000..19f19a39c06d
--- /dev/null
+++ b/mail/youbin/files/youbind.sh.sample
@@ -0,0 +1,10 @@
+#!/bin/sh
+#
+# CAUTION:
+#   Youbin has potentail security problem.
+#   If this program is used on your system, great care must be taken
+#   to avoid any security problem.
+#
+if [ -x @PREFIX@/sbin/youbind ]; then
+    @PREFIX@/sbin/youbind ; echo -n ' youbind'
+fi
diff --git a/mail/youbin/pkg-descr b/mail/youbin/pkg-descr
index f51d97302d1c..a90e97f864e8 100644
--- a/mail/youbin/pkg-descr
+++ b/mail/youbin/pkg-descr
@@ -12,4 +12,5 @@ Since youbin is designed with event driven, the user is promptly
 informed of status change of mail spool caused by arrival of new
 message and/or reading messages.
 
-- Masafumi
+WWW: http://www.agusa.nuie.nagoya-u.ac.jp/software/youbin/youbin-e.html
+- Max
diff --git a/mail/youbin/pkg-req b/mail/youbin/pkg-req
new file mode 100644
index 000000000000..49ca506bd304
--- /dev/null
+++ b/mail/youbin/pkg-req
@@ -0,0 +1,23 @@
+#!/bin/sh
+case "$2" in
+    INSTALL|BUILD)
+	echo '**********************************************************************'
+	echo '*  WARNING!!!                                                        *'
+	echo '*  Youbin has potential security problem!!                           *'
+	echo '*  It is discouraged to use this program to avoid any security       *'
+	echo '*  problem.                                                          *'
+	echo '**********************************************************************'
+	if [ "X${BATCH}" = "Xyes" ]; then
+	   exit 0
+	fi
+	read -p 'Would you like to proceed (y/n)? ' ans
+	case "X$ans" in
+	  Xy*|XY*)
+	    exit 0
+	    ;;
+	  *)
+	    exit 1
+	    ;;
+	esac
+    ;;
+esac