summaryrefslogtreecommitdiff
path: root/lang
diff options
context:
space:
mode:
authorGerald Pfeifer <gerald@FreeBSD.org>2017-11-16 22:13:38 +0000
committerGerald Pfeifer <gerald@FreeBSD.org>2017-11-16 22:13:38 +0000
commitb669b32ce53249cc5f38a4671eb5b019bbab0f3c (patch)
treeacb90136b803b6ce5c58af4fa13bdd279e0ac68b /lang
parentsysutils/intel-nvmupdate: Update to 6.01 (diff)
Backport revision 454177 from lang/gcc7:
Make sure what we install is stripped (i.e., debug info is removed). The straightforward way is setting INSTALL_TARGET to install-strip, which is supported by the upstream GCC build machinery. Unfortunately this fails when running as regular user (non-root) since strip requires write permission to the files in question, and we install binaries as r-xr-xr-x by default. To work around that we need to set BINMODE to allow for write access by the user, something that's common on GNU/Linux (which is why this probably has not been noticed there). This is not necessary when running as root. (A different approach suggested was to set STRIP=true, alas that leads to many files actually not being stripped. This is due to GCC using its own script install-sh that in turn uses cp, chmod, strip,... instead of our own install-* tools in many cases.) According to tests by sobomax@ and me installs of lang/gcc6 went down by about a fourth. Do not bump PORTREVISION since this only changes builds by non-root users, is not a functional change, and the previous state of using a bit more storage had been there "forever". Reported by: Ports QA Framework, miwi, sobomax Discussed with: tijl, miwi Tested by: sobomax Differential Revision: https://reviews.freebsd.org/D10357
Notes
Notes: svn path=/head/; revision=454346
Diffstat (limited to 'lang')
-rw-r--r--lang/gcc5/Makefile4
1 files changed, 4 insertions, 0 deletions
diff --git a/lang/gcc5/Makefile b/lang/gcc5/Makefile
index a3e8afbc1da8..8035e5f53d0d 100644
--- a/lang/gcc5/Makefile
+++ b/lang/gcc5/Makefile
@@ -80,6 +80,10 @@ CONFIGURE_ARGS+=--disable-bootstrap
CONFIGURE_ARGS+=--with-build-config=bootstrap-debug
ALL_TARGET= bootstrap-lean
.endif
+INSTALL_TARGET= install-strip
+.if ${UID} != 0
+BINMODE= 755
+.endif
CONFIGURE_ARGS+=--disable-nls \
--disable-libgcj \
--enable-gnu-indirect-function \