diff options
author | Jung-uk Kim <jkim@FreeBSD.org> | 2010-07-19 21:59:28 +0000 |
---|---|---|
committer | Jung-uk Kim <jkim@FreeBSD.org> | 2010-07-19 21:59:28 +0000 |
commit | 5045cff4a059fb43d185e75ed1258eb9fbe4ca4b (patch) | |
tree | 20aff63270becd83fe367054a3d8fadbd2f72db4 /lang/python26 | |
parent | Update to new upstream release 5.0.26. (diff) |
Fix fcntl module to accept 'unsigned long' type commands for ioctl(2).
Although POSIX says the type is 'int', all BSD variants (including Mac OS X)
have been using 'unsigned long' type for very long time and its use predates
the standard long enough. For certain commands (e.g., TIOCSWINSZ, FIONBIO),
the Python value may get sign-extended on 64-bit platforms (by implicit type
promotion) and it causes annoying warnings from kernel such as this:
WARNING pid 24509 (python2.6): ioctl sign-extension ioctl ffffffff8004667e
Approved by: python (maintainer timeout)
Notes
Notes:
svn path=/head/; revision=257978
Diffstat (limited to 'lang/python26')
-rw-r--r-- | lang/python26/Makefile | 1 | ||||
-rw-r--r-- | lang/python26/files/patch-Doc-library-fcntl.rst | 11 | ||||
-rw-r--r-- | lang/python26/files/patch-Lib-test-test_ioctl.py | 23 | ||||
-rw-r--r-- | lang/python26/files/patch-Modules-fcntlmodule.c | 53 |
4 files changed, 88 insertions, 0 deletions
diff --git a/lang/python26/Makefile b/lang/python26/Makefile index 0eba3df2f32c..e614a36c188e 100644 --- a/lang/python26/Makefile +++ b/lang/python26/Makefile @@ -6,6 +6,7 @@ PORTNAME= python26 PORTVERSION= 2.6.5 +PORTREVISION= 1 CATEGORIES= lang python ipv6 MASTER_SITES= ${PYTHON_MASTER_SITES} MASTER_SITE_SUBDIR= ${PYTHON_MASTER_SITE_SUBDIR} diff --git a/lang/python26/files/patch-Doc-library-fcntl.rst b/lang/python26/files/patch-Doc-library-fcntl.rst new file mode 100644 index 000000000000..58019637a5f6 --- /dev/null +++ b/lang/python26/files/patch-Doc-library-fcntl.rst @@ -0,0 +1,11 @@ +--- Doc/library/fcntl.rst.orig 2009-10-27 10:29:22.000000000 -0400 ++++ Doc/library/fcntl.rst 2010-06-24 22:28:28.000000000 -0400 +@@ -50,8 +50,6 @@ + operations are typically defined in the library module :mod:`termios` and the + argument handling is even more complicated. + +- The op parameter is limited to values that can fit in 32-bits. +- + The parameter *arg* can be one of an integer, absent (treated identically to the + integer ``0``), an object supporting the read-only buffer interface (most likely + a plain Python string) or an object supporting the read-write buffer interface. diff --git a/lang/python26/files/patch-Lib-test-test_ioctl.py b/lang/python26/files/patch-Lib-test-test_ioctl.py new file mode 100644 index 000000000000..f1fdd0ee5fe3 --- /dev/null +++ b/lang/python26/files/patch-Lib-test-test_ioctl.py @@ -0,0 +1,23 @@ +--- Lib/test/test_ioctl.py.orig 2008-05-24 05:36:45.000000000 -0400 ++++ Lib/test/test_ioctl.py 2010-06-24 13:29:31.000000000 -0400 +@@ -44,18 +44,9 @@ class IoctlTests(unittest.TestCase): + raise TestSkipped('pty module required') + mfd, sfd = pty.openpty() + try: +- if termios.TIOCSWINSZ < 0: +- set_winsz_opcode_maybe_neg = termios.TIOCSWINSZ +- set_winsz_opcode_pos = termios.TIOCSWINSZ & 0xffffffffL +- else: +- set_winsz_opcode_pos = termios.TIOCSWINSZ +- set_winsz_opcode_maybe_neg, = struct.unpack("i", +- struct.pack("I", termios.TIOCSWINSZ)) +- ++ set_winsz_opcode = termios.TIOCSWINSZ + our_winsz = struct.pack("HHHH",80,25,0,0) +- # test both with a positive and potentially negative ioctl code +- new_winsz = fcntl.ioctl(mfd, set_winsz_opcode_pos, our_winsz) +- new_winsz = fcntl.ioctl(mfd, set_winsz_opcode_maybe_neg, our_winsz) ++ new_winsz = fcntl.ioctl(mfd, set_winsz_opcode, our_winsz) + finally: + os.close(mfd) + os.close(sfd) diff --git a/lang/python26/files/patch-Modules-fcntlmodule.c b/lang/python26/files/patch-Modules-fcntlmodule.c new file mode 100644 index 000000000000..b8dfd783eca7 --- /dev/null +++ b/lang/python26/files/patch-Modules-fcntlmodule.c @@ -0,0 +1,53 @@ +--- Modules/fcntlmodule.c.orig 2009-05-24 11:41:43.000000000 -0400 ++++ Modules/fcntlmodule.c 2010-06-24 22:27:04.000000000 -0400 +@@ -97,20 +97,15 @@ + { + #define IOCTL_BUFSZ 1024 + int fd; +- /* In PyArg_ParseTuple below, we use the unsigned non-checked 'I' ++ /* In PyArg_ParseTuple below, we use the unsigned non-checked 'k' + format for the 'code' parameter because Python turns 0x8000000 + into either a large positive number (PyLong or PyInt on 64-bit + platforms) or a negative number on others (32-bit PyInt) + whereas the system expects it to be a 32bit bit field value + regardless of it being passed as an int or unsigned long on +- various platforms. See the termios.TIOCSWINSZ constant across +- platforms for an example of thise. +- +- If any of the 64bit platforms ever decide to use more than 32bits +- in their unsigned long ioctl codes this will break and need +- special casing based on the platform being built on. ++ various platforms. + */ +- unsigned int code; ++ unsigned long code; + int arg; + int ret; + char *str; +@@ -118,7 +113,7 @@ + int mutate_arg = 1; + char buf[IOCTL_BUFSZ+1]; /* argument plus NUL byte */ + +- if (PyArg_ParseTuple(args, "O&Iw#|i:ioctl", ++ if (PyArg_ParseTuple(args, "O&kw#|i:ioctl", + conv_descriptor, &fd, &code, + &str, &len, &mutate_arg)) { + char *arg; +@@ -169,7 +164,7 @@ + } + + PyErr_Clear(); +- if (PyArg_ParseTuple(args, "O&Is#:ioctl", ++ if (PyArg_ParseTuple(args, "O&ks#:ioctl", + conv_descriptor, &fd, &code, &str, &len)) { + if (len > IOCTL_BUFSZ) { + PyErr_SetString(PyExc_ValueError, +@@ -191,7 +186,7 @@ + PyErr_Clear(); + arg = 0; + if (!PyArg_ParseTuple(args, +- "O&I|i;ioctl requires a file or file descriptor," ++ "O&k|i;ioctl requires a file or file descriptor," + " an integer and optionally an integer or buffer argument", + conv_descriptor, &fd, &code, &arg)) { + return NULL; |