Upgrade to upstream svn revision r1780246. This incorporates the

pointer comparision fixes required to compile with clang 4.0, so
delete patch-clang40.  Also,
patch-lingucomponent_source_spellcheck_spell_sspellimp.cxx has been
incorporated upstream.

On amd64, clang++ 4.0 uses the MOVAPS SSE instruction to initialize
sufficiently large objects returned by the "new" operator.  This
requires that the object have 16-byte alignment.  The FreeBSD
malloc() implementation does the correct thing here, but OpenOffice
has a couple of internal memory allocator implementations that only
align to 8-byte boundaries at most.  In addition OpenOffice overrides
the new operator to interpose a couple of layers of wrappers.  If
the --enable-debug option is passed to configure, the wrapper adds
8 to the size passed to the allocator and adds an 8 byte offset to
the pointer returned by the allocator to make room for a signature
that it adds to the beginning of the memory block (the signature
is validated and the inverse transformation is done when the memory
is freed).  This breaks the proper alignment done by the mamory
allocator.  Fix these problems by adding an EXTRA_PATCH that teaches
the internal OpenOffice memory allocators to do 16-byte alignment
and to use a 16-byte offset in the "new" wrapper, and apply this
patch on amd64 if clang 4.0 is the system compiler.

Pass the --with-alloc=system flag to configure so that the libc
version of malloc() is used instead of one of the internal memory
allocator implementations.

Fix a few mis-sorts in BUILD_DEPENDS and don't list www/p5-libwww
twice.

Fix a sporadic failure in the clear_001 QA test that occasionally
breaks the build.  The nominal mutex hold time is 5 seconds, but
because it is only checked one per second, the actual time is more
likely to be around 6 seconds.  When the before time value is
subtracted from the after time value, the result might be 7 whole
seconds and a large negative number of nanoseconds.  Since the
pass/fail check only looks at the difference in the seconds fields,
it will fail the "< 7" assertion.  Relax the assertion to "<= 7"
as a quick fix.

Add PowerPC64 support.  [1]

Add a section to pkg-message mentioning that spell check dictionaries
for the desired languages should be installed.  [2]

Various fixes from PR 216245:   [3]
 * Add option for mysql driver, default off.

 * Poppler is only needed for the optional PDF Import extension
   (and we only need poppler and not poppler-glib).

 * The --without-stlport configure flag is not needed.

 * Pass the -with-build-version flag to configure (but use ${PKGNAME}
   for completeness instead of just  ${PORTNAME}-${PORTVERSION})

 * Tweak a comment in the Makefile.

PR:		215130, 212103, 216245
Submitted by:	Curtis Hamilton <hamiltcl@verizon.net> [1]
Submitted by:	Arrigo Marchiori <ardovm AT yahoo.it> [2]
Submitted by:	pfg [3]

6 files changed, 92 insertions, 58 deletions

diff --git a/editors/openoffice-devel/files/Makefile.others b/editors/openoffice-devel/files/Makefile.others
index a8838f2deb93..408e29c41e3e 100644
--- a/editors/openoffice-devel/files/Makefile.others
+++ b/editors/openoffice-devel/files/Makefile.others
@@ -21,11 +21,11 @@ languagepack:
 	@${RM} -fr ${WRKDIR}/langpack_tmp
 	@${MKDIR} ${WRKDIR}/langpack_tmp
 .if defined (LOCALIZED_LANG)
-	@cd ${WRKSRC}/instsetoo_native/unxfbsd?.pro/Apache_OpenOffice_languagepack/archive/install/${LOCALIZED_LANG} ; ls Apache_OpenOffice*tar.* > ${WRKDIR}/${LOCALIZED_LANG}_LANGPACK
+	@cd ${WRKSRC}/instsetoo_native/unxfbsd*.pro/Apache_OpenOffice_languagepack/archive/install/${LOCALIZED_LANG} ; ls Apache_OpenOffice*tar.* > ${WRKDIR}/${LOCALIZED_LANG}_LANGPACK
 	@cd ${WRKDIR}/langpack_tmp ; \
 	for i in `${CAT} ${WRKDIR}/${LOCALIZED_LANG}_LANGPACK`; do \
                 ${ECHO_CMD} "extracting $$i" ; \
-                cd ${WRKDIR}/langpack_tmp ; ${TAR} xfz ${WRKSRC}/instsetoo_native/unxfbsd?.pro/Apache_OpenOffice_languagepack/archive/install/${LOCALIZED_LANG}/$$i ; \
+                cd ${WRKDIR}/langpack_tmp ; ${TAR} xfz ${WRKSRC}/instsetoo_native/unxfbsd*.pro/Apache_OpenOffice_languagepack/archive/install/${LOCALIZED_LANG}/$$i ; \
         done
 	@cd ${WRKDIR}/langpack_tmp/Apache_OpenOffice*/ ; \
 		${MKDIR} ../${INSTALLATION_BASEDIR} ; \
diff --git a/editors/openoffice-devel/files/extra-patch-align16 b/editors/openoffice-devel/files/extra-patch-align16
new file mode 100644
index 000000000000..6d778661e386
--- /dev/null
+++ b/editors/openoffice-devel/files/extra-patch-align16
@@ -0,0 +1,70 @@
+--- sal/cpprt/operators_new_delete.cxx.orig	2014-09-19 17:58:40 UTC
++++ sal/cpprt/operators_new_delete.cxx
+@@ -68,7 +68,7 @@ struct AllocatorTraits
+ 	{
+ 		n = std::max(n, std::size_t(1));
+ #if OSL_DEBUG_LEVEL > 0
+-		n += sizeof(signature_type);
++		n += 2*sizeof(signature_type);
+ #endif  /* OSL_DEBUG_LEVEL  */
+ 		return n;
+ 	}
+@@ -77,7 +77,7 @@ struct AllocatorTraits
+ 	{
+ #if OSL_DEBUG_LEVEL > 0
+ 		memcpy (p, m_signature, sizeof(signature_type));
+-		p = static_cast<char*>(p) + sizeof(signature_type);
++		p = static_cast<char*>(p) + 2*sizeof(signature_type);
+ #endif  /* OSL_DEBUG_LEVEL */
+ 		return p;
+ 	}
+@@ -85,7 +85,7 @@ struct AllocatorTraits
+ 	void* fini (void * p) const SAL_THROW(())
+ 	{
+ #if OSL_DEBUG_LEVEL > 0
+-		p = static_cast<char*>(p) - sizeof(signature_type);
++		p = static_cast<char*>(p) - 2*sizeof(signature_type);
+ 		if (memcmp (p, m_signature, sizeof(signature_type)) != 0)
+ 		{
+ 			OSL_ENSURE(0, "operator delete mismatch");
+--- sal/rtl/source/alloc_cache.c.orig	2016-06-21 21:57:07 UTC
++++ sal/rtl/source/alloc_cache.c
+@@ -894,7 +894,9 @@ rtl_cache_activate (
+ 		if (objalign == 0)
+ 		{
+ 			/* determine default alignment */
+-			if (objsize >= RTL_MEMORY_ALIGNMENT_8)
++			if (objsize >= RTL_MEMORY_ALIGNMENT_16)
++				objalign = RTL_MEMORY_ALIGNMENT_16;
++			else if (objsize >= RTL_MEMORY_ALIGNMENT_8)
+ 				objalign = RTL_MEMORY_ALIGNMENT_8;
+ 			else
+ 				objalign = RTL_MEMORY_ALIGNMENT_4;
+--- sal/rtl/source/alloc_global.c.orig	2016-06-21 21:57:06 UTC
++++ sal/rtl/source/alloc_global.c
+@@ -75,8 +75,8 @@ static rtl_cache_type * g_alloc_caches[R
+ 	0,
+ };
+ 
+-#define RTL_MEMALIGN       8
+-#define RTL_MEMALIGN_SHIFT 3
++#define RTL_MEMALIGN       16
++#define RTL_MEMALIGN_SHIFT 4
+ 
+ static rtl_cache_type * g_alloc_table[RTL_MEMORY_CACHED_LIMIT >> RTL_MEMALIGN_SHIFT] =
+ {
+--- sal/rtl/source/alloc_impl.h.orig	2014-09-19 17:59:16 UTC
++++ sal/rtl/source/alloc_impl.h
+@@ -45,6 +45,12 @@ extern "C" {
+ #define RTL_MEMORY_ALIGNMENT_8 sizeof(void*)
+ #endif /* SAL_TYPES_ALIGNMENT8 */
+ 
++#if defined(SAL_TYPES_ALIGNMENT16) && SAL_TYPES_ALIGNMENT16 > 1
++#define RTL_MEMORY_ALIGNMENT_16 SAL_TYPES_ALIGNMENT16
++#else
++#define RTL_MEMORY_ALIGNMENT_16 16
++#endif /* SAL_TYPES_ALIGNMENT16 */
++
+ #if 0  /* @@@ */
+ #define RTL_MEMORY_ALIGNMENT_1 8
+ #define RTL_MEMORY_ALIGNMENT_2 (sizeof(void*) * 2)
diff --git a/editors/openoffice-devel/files/patch-clang40 b/editors/openoffice-devel/files/patch-clang40
deleted file mode 100644
index 6b2d76f21966..000000000000
--- a/editors/openoffice-devel/files/patch-clang40
+++ /dev/null
@@ -1,39 +0,0 @@
-Index: desktop/source/app/officeipcthread.cxx
-===================================================================
---- desktop/source/app/officeipcthread.cxx	(revision 1779757)
-+++ desktop/source/app/officeipcthread.cxx	(revision 1779758)
-@@ -225,7 +225,7 @@ String CreateMD5FromString( const OUString& aMsg )
- 	// BACK: Str "ababab....0f" Hexcode String
- 
- 	rtlDigest handle = rtl_digest_create( rtl_Digest_AlgorithmMD5 );
--	if ( handle > 0 )
-+	if ( handle != NULL )
- 	{
- 		const sal_uInt8* pData = (const sal_uInt8*)aMsg.getStr();
- 		sal_uInt32		 nSize = ( aMsg.getLength() * sizeof( sal_Unicode ));
-Index: desktop/source/deployment/misc/dp_misc.cxx
-===================================================================
---- desktop/source/deployment/misc/dp_misc.cxx	(revision 1779671)
-+++ desktop/source/deployment/misc/dp_misc.cxx	(revision 1779695)
-@@ -103,7 +103,7 @@ const OUString OfficePipeId::operator () ()
- 	}
-     
-     rtlDigest digest = rtl_digest_create( rtl_Digest_AlgorithmMD5 );
--    if (digest <= 0) {
-+    if (digest == NULL) {
-         throw RuntimeException(
-             OUSTR("cannot get digest rtl_Digest_AlgorithmMD5!"), 0 );
-     }
-Index: sd/source/ui/view/viewshe3.cxx
-===================================================================
---- sd/source/ui/view/viewshe3.cxx	(revision 1779671)
-+++ sd/source/ui/view/viewshe3.cxx	(revision 1779695)
-@@ -226,7 +226,7 @@ SdPage* ViewShell::CreateOrDuplicatePage (
-     // When the given page is NULL then use the first page of the document.
-     SdPage* pTemplatePage = pPage;
-     if (pTemplatePage == NULL)
--        if (pDocument->GetSdPage(0, ePageKind) > 0)
-+        if (pDocument->GetSdPage(0, ePageKind) != NULL)
-             pTemplatePage = pDocument->GetSdPage(0, ePageKind); 
-     if (pTemplatePage != NULL && pTemplatePage->TRG_HasMasterPage())
-         aVisibleLayers = pTemplatePage->TRG_GetMasterPageVisibleLayers();
diff --git a/editors/openoffice-devel/files/patch-lingucomponent_source_spellcheck_spell_sspellimp.cxx b/editors/openoffice-devel/files/patch-lingucomponent_source_spellcheck_spell_sspellimp.cxx
deleted file mode 100644
index b66898b99345..000000000000
--- a/editors/openoffice-devel/files/patch-lingucomponent_source_spellcheck_spell_sspellimp.cxx
+++ /dev/null
@@ -1,14 +0,0 @@
-Minimal exceprt from upstream fix only to unbreak build
-
-https://cgit.freedesktop.org/libreoffice/core/commit/?id=072b32442e3f6f220936a93ad1fcbde57746b747
-
---- lingucomponent/source/spellcheck/spell/sspellimp.cxx.orig	2016-01-29 07:10:27 UTC
-+++ lingucomponent/source/spellcheck/spell/sspellimp.cxx
-@@ -37,7 +37,6 @@
- 
- #include <lingutil.hxx>
- #include <hunspell.hxx>
--#include <dictmgr.hxx>
- #include <sspellimp.hxx>
- 
- #include <linguistic/lngprops.hxx>
diff --git a/editors/openoffice-devel/files/patch-sal_qa_osl_mutex_osl__Mutex.cxx b/editors/openoffice-devel/files/patch-sal_qa_osl_mutex_osl__Mutex.cxx
new file mode 100644
index 000000000000..fe097f86a625
--- /dev/null
+++ b/editors/openoffice-devel/files/patch-sal_qa_osl_mutex_osl__Mutex.cxx
@@ -0,0 +1,11 @@
+--- sal/qa/osl/mutex/osl_Mutex.cxx.orig	2016-06-21 21:57:07 UTC
++++ sal/qa/osl/mutex/osl_Mutex.cxx
+@@ -729,7 +729,7 @@ namespace osl_ClearableGuard
+ 
+ 		myThread.join();
+ 		
+-		ASSERT_TRUE(nSec < 7 && nSec > 1) << "ClearableGuard method: clear";
++		ASSERT_TRUE(nSec <= 7 && nSec > 1) << "ClearableGuard method: clear";
+ 	}
+ 	
+ 	TEST_F(clear, clear_002 )
diff --git a/editors/openoffice-devel/files/pkg-message.in b/editors/openoffice-devel/files/pkg-message.in
index efb32b949e58..815f95d6ddb6 100644
--- a/editors/openoffice-devel/files/pkg-message.in
+++ b/editors/openoffice-devel/files/pkg-message.in
@@ -10,13 +10,19 @@ Apache OpenOffice %%AOOTAG%% will soon be installed in
 --------------------
 To enable the scanner interface, install the sane-backends package.
 
-2. User installation
+2. Spell checkers
+-----------------
+Dictionaries for various languages are available as packages.
+They are named LANG-hunspell, where LANG can be "en", "es", "it" etc.
+The corresponding ports are in the textproc category.
+
+3. User installation
 --------------------
 Just type "%%EXECBASE%%" after you have successfully installed
 the package.  If there is no installed .openoffice.org directory in your
 home directory, the setup installs the "%%AOOUDIR%%" folder.
 
-3. Starting Apache OpenOffice
+4. Starting Apache OpenOffice
 -----------------------------
 There are some wrappers installed for faster startup.  Add "%%PREFIX%%/bin/"
 to your PATH and you will be able to use them.
@@ -32,7 +38,7 @@ to your PATH and you will be able to use them.
 
 OpenOffice does need $LANG to be set to a suitable value.
 
-4. If you run into problems
+5. If you run into problems
 ---------------------------
 If you somehow run into problems, please remove the already installed
 "%%AOOUDIR%%" directory in your home directory, then redo the