From 0175383f0a1f8b78ed514778532f0467a8ccc6dc Mon Sep 17 00:00:00 2001 From: Doug Barton Date: Wed, 15 Jul 2009 16:56:10 +0000 Subject: Fix a few "bad example" problems in the rc.d scripts that have been propogated by copy and paste. 1. Primarily the "empty variable" default assignment, which is mostly ${name}_flags="", but fix a few others as well. 2. Where they are not already documented, add the existence of the _flags (or other deleted empties) option to the comments, and in some cases add comments from scratch. 3. Replace things that look like: prefix=%%PREFIX%% command=${prefix}/sbin/foo to just use %%PREFIX%%. In many cases the $prefix variable is only used once, and in some cases it is not used at all. 4. In a few cases remove ${name}_flags from command_args 5. Remove a long-stale comment about putting the port's rc.d script in /etc/rc.d (which is no longer necessary). No PORTREVISION bumps because all of these changes are noops. --- security/openvpn/files/openvpn.sh.in | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'security/openvpn/files') diff --git a/security/openvpn/files/openvpn.sh.in b/security/openvpn/files/openvpn.sh.in index 84da0a29b940..ca66486c06ab 100644 --- a/security/openvpn/files/openvpn.sh.in +++ b/security/openvpn/files/openvpn.sh.in @@ -75,8 +75,6 @@ esac rcvar=$(set_rcvar) -prefix="%%PREFIX%%" - openvpn_precmd() { for i in $interfaces ; do @@ -118,8 +116,8 @@ load_rc_config ${name} eval ": \${${name}_enable:=\"NO\"}" eval ": \${${name}_flags:=\"\"}" eval ": \${${name}_if:=\"\"}" -eval ": \${${name}_configfile:=\"${prefix}/etc/openvpn/${name}.conf\"}" -eval ": \${${name}_dir:=\"${prefix}/etc/openvpn\"}" +eval ": \${${name}_configfile:=\"%%PREFIX%%/etc/openvpn/${name}.conf\"}" +eval ": \${${name}_dir:=\"%%PREFIX%%/etc/openvpn\"}" configfile="$(eval echo \${${name}_configfile})" dir="$(eval echo \${${name}_dir})" -- cgit v1.2.3