From fddd6110e00df12c99a20a2cc9d074f5f4f1f965 Mon Sep 17 00:00:00 2001 From: Evgeniy Khramtsov Date: Sun, 30 Apr 2017 19:01:47 +0300 Subject: Don't validate an option in gen_mod:get*opt() functions The changes are very similar to those from previous commit: * Now there is no need to pass validating function in gen_mod:get_opt() and gen_mod:get_module_opt() functions, because the modules' configuration keeps already validated values. * New functions gen_mod:get_opt/2 and gen_mod:get_module_opt/3 are introduced. * Functions gen_mod:get_opt/4 and get_module_opt/5 are deprecated. If the functions are still called, the "function" argument is simply ignored. * Validating callback Mod:listen_opt_type/1 is introduced to validate listening options at startup. --- src/mod_service_log.erl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/mod_service_log.erl') diff --git a/src/mod_service_log.erl b/src/mod_service_log.erl index 46fae921..1c6e5fe8 100644 --- a/src/mod_service_log.erl +++ b/src/mod_service_log.erl @@ -68,8 +68,7 @@ log_user_receive({Packet, C2SState}) -> -spec log_packet(stanza(), binary()) -> ok. log_packet(Packet, Host) -> - Loggers = gen_mod:get_module_opt(Host, ?MODULE, loggers, - mod_opt_type(loggers), []), + Loggers = gen_mod:get_module_opt(Host, ?MODULE, loggers, []), ForwardedMsg = #message{from = jid:make(Host), id = randoms:get_string(), sub_els = [#forwarded{ -- cgit v1.2.3